Closed Bug 848263 Opened 11 years ago Closed 11 years ago

Use HTTPS instead of HTTP for in-product support.mozilla.org links for metro

Categories

(Firefox for Metro Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 24

People

(Reporter: raymondlee, Assigned: ananuti)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #840687 +++
+++ This bug was initially created as a clone of Bug #771788 +++

app.support.baseURL;http://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/

Should become https:// at some point.

(In reply to James Socol [:jsocol, :james] from comment #2)
> (In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment
> #1)
> > These bugs are probably best filed per-host. support.mozilla.org link
> > changes require sign-off from different people than mozilla.com links. I
> > think mozilla.com/org can probably just be changed wholesale.
> 
> support.mozilla.org in particular is not really designed to have all traffic
> come over HTTPS right now. I don't think it would cause the site to fall
> over, but there are changes we would really rather make before Firefox
> changed to HTTPS-only.
I'm happy to review a patch for this, but we won't be able to land the patch until the SUMO team is ready (bug 848520).

This is a good trivial bug for someone getting started in Firefox development who wants to contribute a patch.  It's just a change to the pref value in this file:
http://mxr.mozilla.org/mozilla-central/source/browser/metro/profile/metro.js
Blocks: metrov2planning
No longer blocks: metrov1triage
Depends on: 848520
Whiteboard: [mentor=mbrubeck@mozilla.com][good first bug][lang=js]
Attached patch proposed patch (obsolete) (deleted) — Splinter Review
Assignee: nobody → ananuti
Attachment #722640 - Flags: review?(mbrubeck)
Comment on attachment 722640 [details] [diff] [review]
proposed patch

Wow, that was quick.  Thanks!

As mentioned above, this patch can land once the support.mozilla.org team is ready for it.
Attachment #722640 - Flags: review?(mbrubeck) → review+
Whiteboard: [mentor=mbrubeck@mozilla.com][good first bug][lang=js]
We are all set from the SUMO side here. We've been redirecting all the in-product links to https for a few weeks now and haven't had any issues.
Attached patch Unbitrotted patch (deleted) — Splinter Review
Attachment #722640 - Attachment is obsolete: true
Attachment #754799 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ca8a60fff495
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: