Closed
Bug 848415
Opened 12 years ago
Closed 12 years ago
[Dialer] Create performance tests for the call log
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Firefox OS Graveyard
Gaia::Dialer
Tracking
(b2g18 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g18 | --- | fixed |
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
Attachments
(1 file)
(deleted),
text/html
|
etienne
:
review+
akeybl
:
approval-gaia-v1+
|
Details |
No description provided.
Updated•12 years ago
|
Assignee: nobody → josea.olivera
Assignee | ||
Updated•12 years ago
|
Assignee: josea.olivera → ferjmoreno
Assignee | ||
Comment 1•12 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•12 years ago
|
Attachment #725042 -
Flags: review?(etienne)
Assignee | ||
Updated•12 years ago
|
Blocks: gaia-perf-measure
Comment 3•12 years ago
|
||
Comment on attachment 725042 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8652
cool!
Attachment #725042 -
Flags: review?(etienne) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 5•12 years ago
|
||
FYI, this test doesn't show up on Datazilla because of bug 851195. The fact that FTU fails is a problem for the next app to be tested and that's dialer right now. See the output of http://qa-selenium.mv.mozilla.com:8080/view/B2G/job/b2g.unagi.gaia.master.mozperftest/152/artifact/perf.json
Comment 6•12 years ago
|
||
And now, it doesn't show up because the reference-workload can't be created for the dialer.
"Skipped dialer history - no communications DB directory found..."
http://qa-selenium.mv.mozilla.com:8080/view/B2G/job/b2g.unagi.gaia.master.mozperftest/159/consoleText
Assignee | ||
Comment 7•12 years ago
|
||
Thanks for the information Rik!
I am afraid that I have no access to the link that you are providing :(.
I noticed that the reference workload could not be created for the dialer while developing these tests as the patch landed in https://github.com/mozilla-b2g/gaia/pull/8546 wasn't enough. I reported it to Gregor Wagner (reviewer of the previous PR) and it seems that Jon Hylands already fixed it in bug 851249. Is this still an issue after bug 851249 landed?
Comment 8•12 years ago
|
||
(Sorry for the link behind our VPN, I forgot about that.)
Let's followup in bug 852541 as it doesn't seem trivial to fix.
Comment 9•12 years ago
|
||
Comment on attachment 725042 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8652
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: Harder to track performance improvements on v1-train
Testing completed:
Risk to taking this patch (and alternatives if risky): low, no functional change
String or UUID changes made by this patch:
Attachment #725042 -
Flags: approval-gaia-v1?(bfrancis)
Comment 10•12 years ago
|
||
Comment on attachment 725042 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8652
Basically npotb, approving for uplift.
Attachment #725042 -
Flags: approval-gaia-v1?(bfrancis) → approval-gaia-v1+
Comment 11•12 years ago
|
||
I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with:
git checkout v1-train
git cherry-pick -x -m1 7fc1cc5c5d3bfdcefc48efcb1ed0a3e973b89862
<RESOLVE MERGE CONFLICTS>
git commit
Updated•12 years ago
|
Flags: needinfo?(ferjmoreno)
Comment 12•12 years ago
|
||
It looks like this merge conflicts because of bug 845274 not merged yet.
Flags: needinfo?(ferjmoreno)
Comment 13•12 years ago
|
||
Uplifted commit 7fc1cc5c5d3bfdcefc48efcb1ed0a3e973b89862 as:
v1-train: f2b6d1f39c6c6c495b853e13377360ab01484d8f
status-b2g18:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•