Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Description • 12 years ago

Panos recently mentioned (bug 785704 comment 17) that he thinks we should remove these packets. It would make my work in bug 772119 easier as well. Best not to have extra technical debt that we don't need.

However, this involves reworking our backwards compat tests.

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 1 • 12 years ago

https://tbpl.mozilla.org/?tree=Try&rev=edce9cf9b783

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 2 • 12 years ago

Comment on attachment 722442 [details] [diff] [review]
v1

Review of attachment 722442 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/debugger/dbg-client.jsm
@@ +695,5 @@
>  
>  SSProto.name = "sources";
>  
>  SSProto.onPacketTest = function SS_onPacketTest(aPacket) {
> +  dump();

Ditch the dump() calls in this file.

::: toolkit/devtools/debugger/server/dbg-script-actors.js
@@ +662,5 @@
>    onSources: function TA_onSources(aRequest) {
>      this._discoverScriptsAndSources();
>      let urls = Object.getOwnPropertyNames(this._sources);
>      return {
>        sources: [this._getSource(url).form() for (url of urls)]

Perhaps you can now inline _getSource?

::: toolkit/devtools/debugger/tests/unit/test_sources_backwards_compat-01.js
@@ +39,5 @@
>  }
>  
>  function test_new_source_compatibility()
>  {
> +  dump("FITZGEN: inside test_new_source_compatibility\n");

Moar dump()s!

::: toolkit/devtools/debugger/tests/unit/testcompatactors.js
@@ +42,5 @@
> +              let script = {
> +                url: url,
> +                startLine: i,
> +                lineCount: this._scripts[url][i].lineCount,
> +                source: this._getSource(url).form()

Ah, so you are still using _getSource here.

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 3 • 12 years ago

Ame as v1, but without the dump logs.

Sorry, Panos! I need to make a checklist (or better yet a script) for all these little things. In fact, I think I need a whole suite of mozilla specific commands...

Ask JimB about checklists sometime, he has a great article to share :)

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 4 • 12 years ago

Rebasing on fx-team

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 5 • 12 years ago

https://hg.mozilla.org/integration/fx-team/rev/b446612962cf

	Tim Taubert [:ttaubert] (inactive)
	Comment 6 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/b446612962cf