Closed
Bug 848581
Opened 12 years ago
Closed 12 years ago
Enable cubeb by default on gonk
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: mwu, Assigned: mwu)
References
Details
Attachments
(1 file)
(deleted),
patch
|
kinetik
:
review+
mchen
:
feedback+
|
Details | Diff | Splinter Review |
Once bug 839007 is fixed, we can finally switch to the cubeb backend on gonk.
Attachment #721922 -
Flags: review?(kinetik)
Assignee | ||
Comment 1•12 years ago
|
||
Comment on attachment 721922 [details] [diff] [review]
Enable cubeb by default on gonk
mchen, do you think the cubeb backend is ready? Or are there other things that need to be fixed before we enable this?
Attachment #721922 -
Flags: feedback?(mchen)
Comment 2•12 years ago
|
||
Comment on attachment 721922 [details] [diff] [review]
Enable cubeb by default on gonk
Sounds good to me.
Attachment #721922 -
Flags: review?(kinetik) → review+
Comment 3•12 years ago
|
||
Comment on attachment 721922 [details] [diff] [review]
Enable cubeb by default on gonk
Review of attachment 721922 [details] [diff] [review]:
-----------------------------------------------------------------
I tried to do some testing and there is no obvious error or crash.
so I think it can be enabled after fixing the known crash issue.
Attachment #721922 -
Flags: feedback?(mchen) → feedback+
Comment 4•12 years ago
|
||
We need also need bug 839415 landed before we can land this.
Depends on: 839415
Comment 5•12 years ago
|
||
Hi Matthew & Michael,
May I know that libcubeb will be planed to enable on V1.X?
At least bug 842195 waits for this.
Thanks.
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Marco Chen [:mchen] from comment #5)
> Hi Matthew & Michael,
>
> May I know that libcubeb will be planed to enable on V1.X?
> At least bug 842195 waits for this.
>
> Thanks.
Feel free to check this patch in right now if you want.
Assignee | ||
Comment 7•12 years ago
|
||
Oh I misread your comment.
I was expecting this to be for v2.0. If you need cubeb on v1.1, we'll need approval to land all the patches to support this. We need to enable this on trunk first, at any rate.
Comment 8•12 years ago
|
||
I was intending to land this on mozilla-central and let it trickle to B2G that way (so presumably it'd end up in 2.x?). If you or Michael think we should push it back into 1.x, I have no objections; we'll just need to be more careful with testing.
Comment 9•12 years ago
|
||
I think it would be better on V2.0 or V1.2 because chip vendor, partner and Mozilla did much tests on sydney already and LPA seems to be evaluted by chip vendor on sydney now. If the decision is made, I will reply to bug 842195 then start to hack mozWriteAudio API for sydney backend.
So the decision will be on v2.0?
Any suggestion?
Comment 10•12 years ago
|
||
Comment 11•12 years ago
|
||
Yep, 2.0 makes sense to me.
Comment 12•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•