Closed
Bug 848775
Opened 12 years ago
Closed 12 years ago
Turn off WAI-ARIA live politeness in Firefox status bar
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
VERIFIED
FIXED
Firefox 22
People
(Reporter: MarcoZ, Assigned: MarcoZ)
References
Details
(Keywords: access)
Attachments
(1 file)
(deleted),
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
After bug 396166 landed, the status bar live region, made out of XUL labels, suddenly started speaking again with NVDA. However the text spoken is disjointed and fragmented. It sounds like "tr" "nsfer" "ata" etc., as if the text isn't being pushed in at once or retrieval somehow fails.
This was reported on Twitter by a user and confirmed by me.
Comment 1•12 years ago
|
||
Jamie, it'd be great if you figure out what's wrong with our implementation.
Flags: needinfo?(jamie)
Comment 2•12 years ago
|
||
I would argue that the status bar should not be a live region at all, or only be perhaps while the document is busy. Right now an AT is instructed to announce changes to the status bar at all times, including when moving the focus between links (the URL changes on the status bar). The fact that this info is coming to NVDA disjointed is in my opinion not really the major issue here.
The status bar currently has live:polite. This is either there specifically, or is getting it because the role is status perhaps?
Either way, this never happened in the past, and while it exists it makes Firefox extremely unusable with NVDA.
I would strongly argue that this is a bad use of live regions, thus I don't think it should be up to the AT to filter this.
Unless there is already another bug specifically for this, I would suggest renaming the summary to reflect the more pressing issue.
Updated•12 years ago
|
Flags: needinfo?(jamie)
Comment 3•12 years ago
|
||
Marco, what about Michael suggestion to remove live regions from firefox status bar?
Flags: needinfo?(marco.zehe)
Comment 4•12 years ago
|
||
Just for further background:
(In reply to Michael Curran from comment #2)
> The status bar currently has live:polite. This is either there specifically,
> or is getting it because the role is status perhaps?
role="status" implies aria-live="polite". It should be possible to override this with aria-live="off".
> Either way, this never happened in the past,
That's because of bug 396166, which meant that the status bar didn't have accessible text, even though it was a live region.
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to alexander :surkov from comment #3)
> Marco, what about Michael suggestion to remove live regions from firefox
> status bar?
Then things would go back to the way things were before bug the text became AccessibleText: NVDA would simply not speak the updates from the status bar. Compared with the distracting babbling that happens now, that would be more than acceptable, at least it wouldn't appear that we regressed.
Flags: needinfo?(marco.zehe)
Comment 6•12 years ago
|
||
Dao, can you take a look please? (status bar shouldn't be a live region, see comment #4)
Comment 7•12 years ago
|
||
(In reply to James Teh [:Jamie] from comment #4)
> role="status" implies aria-live="polite". It should be possible to override
> this with aria-live="off".
The label is here:
http://hg.mozilla.org/mozilla-central/annotate/a73a2b5c423b/browser/base/content/tabbrowser.xml#l4487
If someone wants to provide a patch, I can review it.
Comment 8•12 years ago
|
||
Marco, would you willing to fix this one?
Assignee | ||
Updated•12 years ago
|
Component: Disability Access APIs → Tabbed Browser
Product: Core → Firefox
Summary: NVDA only gets text from status bar live region in disjointed chunks → Turn off WAI-ARIA live politeness in Firefox status bar
Assignee | ||
Comment 10•12 years ago
|
||
Keep the role "status" so the semantics are unchanged in case assistive technologies rely on it, just change the aria-live politeness to off.
Attachment #728119 -
Flags: review?(dao)
Comment 11•12 years ago
|
||
(In reply to Marco Zehe (:MarcoZ) from comment #10)
> Keep the role "status" so the semantics are unchanged in case assistive
> technologies rely on it
Not only this, but the status bar role is semantically correct here; i.e. it shouldn't be changed even if AT don't rely on it. :)
Assignee | ||
Comment 12•12 years ago
|
||
A try build with this change is here, and I've verified with it that the patch works as intended:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mzehe@mozilla.com-4b349aa59978
Updated•12 years ago
|
Attachment #728119 -
Flags: review?(dao) → review+
Assignee | ||
Comment 13•12 years ago
|
||
Comment 14•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Assignee | ||
Comment 15•12 years ago
|
||
Jamie, can you verify that this now works as expected in NVDA, including that you still get the status bar exposed as expected? Thanks!
Flags: needinfo?(jamie)
Comment 16•12 years ago
|
||
(In reply to Marco Zehe (:MarcoZ) from comment #15)
> Jamie, can you verify that this now works as expected in NVDA, including
> that you still get the status bar exposed as expected? Thanks!
Verified working nicely in 22.0a1 (2013-03-25).
Status: RESOLVED → VERIFIED
Flags: needinfo?(jamie)
You need to log in
before you can comment on or make changes to this bug.
Description
•