The `l10n_date.js' library is loaded at startup tough it’s not required by the main panel. We could shave of a bit of startup time by loading this library only in the three panels that really require it: • Languages • Date & Time • Device Information

Comment on attachment 724994 [details] link to pull request If you can provide some values for the performance gains it will surely help for the uplift decision.

Comment on attachment 724994 [details] link to pull request r=me. I have no concerns about this. :p

Kaze, could you please add the measurements for the gains this patch haves ? So that we can ask an approval..

Results of my perf test runs : before patch : "mozPerfDurations": [ 1175, 1062, 1280, 1058, 1153 ], "mozPerfDurationsAverage": 1145.6 after patch: "mozPerfDurations": [ 1131, 1140, 1082, 1077, 990 ], "mozPerfDurationsAverage": 1084 So we seem to gain around 60ms with this, not bad !

Comment on attachment 724994 [details] link to pull request NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): - User impact if declined: settings launches slower Testing completed: yes Risk to taking this patch (and alternatives if risky): low, the patch is small enough so that we understand all the implications String or UUID changes made by this patch: none

Thanks for the measurement!

Tracking so we can get an uplift nomination for v1.1/v1-train but leaving tef? so that can be evaluated by OEMs for consideration.

Bug 817048 isn't marked as a tef blocker, so improvements wouldn't block either. that being said, uplifting this low risk patch for v1.1 makes sense.

I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1-train git cherry-pick -x -m1 d29b590e08614cda4bdfe54f188a1d456c656037 <RESOLVE MERGE CONFLICTS> git commit

The conflict comes from bug 828890 not being uplifted yet, but since I think it will be, lets wait for it.

approval has been given in bug 828890.

(In reply to Julien Wajsberg [:julienw] from comment #13) > approval has been given in bug 828890. That bug is dependent on bug 858722, which isn't reviewed yet.

Uplifted commit d29b590e08614cda4bdfe54f188a1d456c656037 as: v1-train: b7a38a6e635829023db3bad35d0f8412f3b56233