So I was thinking of changing the names of our internal eCSSProperty_* constants to use the property names that are used for DOM methods. In other words, I'd change: eCSSProperty_font_size -> eCSSProperty_FontSize This would allow removing a field from nsCSSPropList.h . It would also match what I did for property alias names in bug 849656.

What do you all think of this idea?

Seems reasonable to me.

Sounds fine.

Seems OK.

Comment on attachment 728853 [details] [diff] [review] patch 1: Expose CSS_PROP_PUBLIC_OR_PRIVATE macro to users of nsCSSPropList.h rather than CSS_PROP_DOMPROP_PREFIXED, so that we can avoid 'CssFloat' spreading even further. r=me

Comment on attachment 728854 [details] [diff] [review] patch 2: Change internal uses of 'CssFloat' to 'Float'. r=me

OK, those initial patches landed: remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/eb8d19e9c838 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d20bf3793eb2 I think I need to write the primary substitution patch using sed.

Plus bustage fix: https://hg.mozilla.org/integration/mozilla-inbound/rev/3178d9b2406d

https://hg.mozilla.org/mozilla-central/rev/eb8d19e9c838 https://hg.mozilla.org/mozilla-central/rev/d20bf3793eb2 https://hg.mozilla.org/mozilla-central/rev/3178d9b2406d

(We should perhaps make this an enum class at the same time, actually.)