Closed
Bug 849699
Opened 12 years ago
Closed 12 years ago
Defect - Cannot Select Email/Password Text Boxes on Twitter
Categories
(Firefox for Metro Graveyard :: Browser, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: kjozwiak, Assigned: bbondy)
References
Details
(Whiteboard: feature=defect c=Content_features u=metro_firefox_user p=3)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
When visiting Twitter using the Metro browser, sometimes you cannot place the cursor into the Email/Password fields making it impossible to login. You have to refresh the website until you can place the cursor into the fields. If you do place the cursor inside the fields, you will notice a very large border appear around the selected field.
Steps to reproduce the issue:
1) Open the Metro browser
2) Go to the Twitter page (make sure you are not logged in)
3) Try inserting your cursor into either the Email or Password fields (If you do end up selecting the fields, you will notice a border appear around the selected field)
Actual Results:
- Cannot select the Email or Password fields (or a border appears when you do end up selecting them)
Expected Results:
- Should be able to select the fields without any problems and no borders
Assignee | ||
Comment 1•12 years ago
|
||
Confirmed, ouch! We should fix this soon.
Username and password fields will not accept focus.
Priority: -- → P1
Assignee | ||
Updated•12 years ago
|
Whiteboard: p=3
Assignee | ||
Comment 2•12 years ago
|
||
I noticed that you can hit the tab key with your keyboard to get focus in the username and password fields, but touch and mouse do not work.
Updated•12 years ago
|
Flags: needinfo?(asa)
Updated•12 years ago
|
QA Contact: jbecerra
Summary: cannot select Email/Password text boxes on Twitter → Defect - Cannot Select Email/Password Text Boxes on Twitter
Whiteboard: p=3 → feature=defect c=tbd u=tbd p=3
Comment 3•12 years ago
|
||
Do we have a regression range on this, or has it always been broken?
Assignee | ||
Updated•12 years ago
|
Keywords: regressionwindow-wanted
Reporter | ||
Comment 4•12 years ago
|
||
I'm not sure if it was always broken but I'll try an older build and if it doesn't work then I'll use mozregression ( http://mozilla.github.com/mozregression/ ) to find the regression range.
Comment 5•12 years ago
|
||
Yeah. This is top 10 site. We gotta get touch focusing the forms and bringing up the OSK.
Flags: needinfo?(asa)
Assignee | ||
Comment 6•12 years ago
|
||
This is not just touch by the way Asa, you can't even select it with your mouse.
Comment 7•12 years ago
|
||
Hi Asa, is this defect better represented by a story from iterations #0 - #3?
Flags: needinfo?(asa)
Whiteboard: feature=defect c=tbd u=tbd p=3 → feature=defect c=Content_features u=metro_firefox_user p=3
Assignee | ||
Comment 8•12 years ago
|
||
Marco I'll mark it as blocking story bug 801121 for now, but I'm not sure if it was introduced there. We can change it later if needed. Once Kamil does the regression range we will know better.
Assignee | ||
Comment 9•12 years ago
|
||
Actually bug 831977 is probably a better guess.
Comment 10•12 years ago
|
||
Sounds good. Thanks for the update Brian.
Updated•12 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 11•12 years ago
|
||
Works:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/01/2013-01-31-04-02-03-elm/
Doesn't work:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/02/2013-02-16-03-11-27-mozilla-central/
Doesn't work:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/02/2013-02-10-04-02-02-elm/
Doesn't work:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/02/2013-02-05-04-02-03-elm/
Works:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/02/2013-02-02-04-02-02-elm/
Doesn't work:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/02/2013-02-04-04-02-02-elm/
No build for 2013-02-03 for elm so the regression range is:
- 2013-02-02 to 2013-02-04
LoginManager looks like it landed within this range and so I think the blocking bug is the right one.
Reporter | ||
Updated•12 years ago
|
Keywords: regressionwindow-wanted
Assignee | ||
Comment 12•12 years ago
|
||
Awesome, thank you!
Assignee | ||
Comment 13•12 years ago
|
||
Assignee | ||
Comment 14•12 years ago
|
||
Assignee | ||
Comment 15•12 years ago
|
||
Removing this code in the attached patch makes focus work correctly for the sign in fields on twitter.com. It also doesn't break autocomplete in general in any way I can see.
Maybe it's related to removing this previously but I re-enabled that and it didn't help the problem.
https://hg.mozilla.org/projects/elm/rev/d788e35a91ba#l2.12
I think we should take this for now but let me know if you have a better suggestion.
Attachment #725096 -
Flags: review?(mbrubeck)
Assignee | ||
Comment 16•12 years ago
|
||
I think it is correct. It seems like these lines:
https://hg.mozilla.org/projects/elm/rev/d788e35a91ba#l2.19
Were at one point enabled and that's why the extra focus code was needed.
But when those lines were commented out (at some point by someone) they didn't update the code in this patch.
Updated•12 years ago
|
Attachment #725096 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 17•12 years ago
|
||
Thanks for the quick reviews (that you always give :)).
By the way I still plan to get to the login manager tests as I have time between iteration tasks.
Assignee | ||
Comment 18•12 years ago
|
||
inbound has been down for a while, marking checkin-needed.
Keywords: checkin-needed
Assignee | ||
Comment 19•12 years ago
|
||
Same but with a proper commit message
Attachment #725096 -
Attachment is obsolete: true
Attachment #725202 -
Flags: review+
Comment 20•12 years ago
|
||
Keywords: checkin-needed
Comment 22•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Flags: needinfo?(jbecerra)
Reporter | ||
Comment 23•12 years ago
|
||
Tried reproducing the issue using the latest Nightly build without any issues:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-03-17-03-09-23-mozilla-central/
Went through the same steps as posted before without any problems. Tried several other websites such as Facebook to make sure its working correctly.
Removing need info since I think I'm providing the info needed to verify this task.
Status: RESOLVED → VERIFIED
Flags: needinfo?(jbecerra)
Reporter | ||
Comment 24•12 years ago
|
||
Went through the following "Defect" for iteration #6 testing. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-30-03-09-41-mozilla-central/
Once again, went through the original test case in Comment 0 and also tried several other websites without any issues.
Reporter | ||
Comment 25•11 years ago
|
||
Went through the following "Defect" for iteration #12 testing without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-21-05-01-36-mozilla-central/
- Went through the original test case in comment #0 without any issues
- Tried several other websites and ensured that you can tab/click into the username and password fields
- Went through all of the above test cases in filled view without any issues
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•