Closed Bug 849699 Opened 12 years ago Closed 12 years ago

Defect - Cannot Select Email/Password Text Boxes on Twitter

Categories

(Firefox for Metro Graveyard :: Browser, defect, P1)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: kjozwiak, Assigned: bbondy)

References

Details

(Whiteboard: feature=defect c=Content_features u=metro_firefox_user p=3)

Attachments

(1 file, 1 obsolete file)

When visiting Twitter using the Metro browser, sometimes you cannot place the cursor into the Email/Password fields making it impossible to login. You have to refresh the website until you can place the cursor into the fields. If you do place the cursor inside the fields, you will notice a very large border appear around the selected field. Steps to reproduce the issue: 1) Open the Metro browser 2) Go to the Twitter page (make sure you are not logged in) 3) Try inserting your cursor into either the Email or Password fields (If you do end up selecting the fields, you will notice a border appear around the selected field) Actual Results: - Cannot select the Email or Password fields (or a border appears when you do end up selecting them) Expected Results: - Should be able to select the fields without any problems and no borders
Confirmed, ouch! We should fix this soon. Username and password fields will not accept focus.
Priority: -- → P1
Whiteboard: p=3
I noticed that you can hit the tab key with your keyboard to get focus in the username and password fields, but touch and mouse do not work.
Flags: needinfo?(asa)
Blocks: metrov1it4
No longer blocks: metrov1triage
QA Contact: jbecerra
Summary: cannot select Email/Password text boxes on Twitter → Defect - Cannot Select Email/Password Text Boxes on Twitter
Whiteboard: p=3 → feature=defect c=tbd u=tbd p=3
Do we have a regression range on this, or has it always been broken?
I'm not sure if it was always broken but I'll try an older build and if it doesn't work then I'll use mozregression ( http://mozilla.github.com/mozregression/ ) to find the regression range.
Blocks: 831982
Yeah. This is top 10 site. We gotta get touch focusing the forms and bringing up the OSK.
Flags: needinfo?(asa)
This is not just touch by the way Asa, you can't even select it with your mouse.
Hi Asa, is this defect better represented by a story from iterations #0 - #3?
Flags: needinfo?(asa)
Whiteboard: feature=defect c=tbd u=tbd p=3 → feature=defect c=Content_features u=metro_firefox_user p=3
Marco I'll mark it as blocking story bug 801121 for now, but I'm not sure if it was introduced there. We can change it later if needed. Once Kamil does the regression range we will know better.
Assignee: nobody → netzen
Blocks: 801121
No longer blocks: 831982
Flags: needinfo?(asa)
Actually bug 831977 is probably a better guess.
Blocks: 831977
No longer blocks: 801121
Sounds good. Thanks for the update Brian.
Status: NEW → ASSIGNED
Awesome, thank you!
Attached patch Patch v1. (obsolete) (deleted) — Splinter Review
Removing this code in the attached patch makes focus work correctly for the sign in fields on twitter.com. It also doesn't break autocomplete in general in any way I can see. Maybe it's related to removing this previously but I re-enabled that and it didn't help the problem. https://hg.mozilla.org/projects/elm/rev/d788e35a91ba#l2.12 I think we should take this for now but let me know if you have a better suggestion.
Attachment #725096 - Flags: review?(mbrubeck)
I think it is correct. It seems like these lines: https://hg.mozilla.org/projects/elm/rev/d788e35a91ba#l2.19 Were at one point enabled and that's why the extra focus code was needed. But when those lines were commented out (at some point by someone) they didn't update the code in this patch.
Attachment #725096 - Flags: review?(mbrubeck) → review+
Thanks for the quick reviews (that you always give :)). By the way I still plan to get to the login manager tests as I have time between iteration tasks.
inbound has been down for a while, marking checkin-needed.
Keywords: checkin-needed
Attached patch Patch v2. (deleted) — Splinter Review
Same but with a proper commit message
Attachment #725096 - Attachment is obsolete: true
Attachment #725202 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: needinfo?(jbecerra)
Tried reproducing the issue using the latest Nightly build without any issues: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-03-17-03-09-23-mozilla-central/ Went through the same steps as posted before without any problems. Tried several other websites such as Facebook to make sure its working correctly. Removing need info since I think I'm providing the info needed to verify this task.
Status: RESOLVED → VERIFIED
Flags: needinfo?(jbecerra)
Went through the following "Defect" for iteration #6 testing. Used the following build: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-30-03-09-41-mozilla-central/ Once again, went through the original test case in Comment 0 and also tried several other websites without any issues.
Went through the following "Defect" for iteration #12 testing without any issues. Used the following build: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-21-05-01-36-mozilla-central/ - Went through the original test case in comment #0 without any issues - Tried several other websites and ensured that you can tab/click into the username and password fields - Went through all of the above test cases in filled view without any issues
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: