Closed
Bug 849725
Opened 12 years ago
Closed 11 years ago
B2G RIL: remove RIL.iccInfoPrivate.SPN.spn
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: kk1fff, Assigned: kk1fff)
Details
Attachments
(1 file, 3 obsolete files)
This properity isn't used and the spn string is also stored in RIL.iccInfo.spn. We can remove spn string from iccInfoPrivate.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #749126 -
Flags: review?(allstars.chh)
Comment on attachment 749126 [details] [diff] [review]
Remove spn from iccInfoPriv.SPN
Review of attachment 749126 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/system/gonk/ril_worker.js
@@ +10166,1 @@
> };
It seems we can make it become
RIL.iccInfoPrivate.spnDisplayCondtion, without wrapping by another SPN object, right?
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #749126 -
Attachment is obsolete: true
Attachment #749126 -
Flags: review?(allstars.chh)
Attachment #749186 -
Flags: review?(allstars.chh)
Assignee | ||
Comment 4•11 years ago
|
||
fix xpcshell failure.
Attachment #749186 -
Attachment is obsolete: true
Attachment #749186 -
Flags: review?(allstars.chh)
Attachment #749723 -
Flags: review?(allstars.chh)
Comment on attachment 749723 [details] [diff] [review]
Patch: use iccInfoPriv.spnDisplayCondition to store display condition v3
Review of attachment 749723 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/system/gonk/ril_worker.js
@@ +11219,3 @@
> iccInfo.isDisplayNetworkNameRequired = true;
> } else {
> iccInfo.isDisplayNetworkNameRequired = false;
we could make this remove this if block by
iccInfo.isDisplayNetworkNameRequired = (displayCondition & 0x01) != 0;
also with & 0x2 below.
But it doesn't matter too much so I leave you to decide.
Attachment #749723 -
Flags: review?(allstars.chh) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Assignee | ||
Comment 7•11 years ago
|
||
Attachment #749723 -
Attachment is obsolete: true
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox22:
--- → wontfix
status-firefox23:
--- → wontfix
status-firefox24:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•