Closed
Bug 849955
Opened 12 years ago
Closed 12 years ago
Add a way to exit fennec on ouya
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
On the latest ouya firmware, the "home" button is mapped to the menu, so there's no way to get out of fennec. Killing it via adb resurrects it immediately as well, presumably because ouya's firmware is "helpfully" restarting it for some reason or another.
Comment 1•12 years ago
|
||
If HOME is MENU, how do other apps handle this situation?
Assignee | ||
Comment 2•12 years ago
|
||
Put back quit button for non-touchscreen devices. You can't swipe-kill the app if there's no touchscreen.
Assignee: nobody → bugmail.mozilla
Attachment #723618 -
Flags: review?(sriram)
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #1)
> If HOME is MENU, how do other apps handle this situation?
The app store on ouya isn't working yet so I don't have any other apps to try :(
Comment 4•12 years ago
|
||
Comment on attachment 723618 [details] [diff] [review]
Patch
Review of attachment 723618 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #723618 -
Flags: review?(sriram) → review+
Comment 5•12 years ago
|
||
In the new update, a single tap is MENU, but a double tap is HOME. (Also a long press is HOME on post-devkit controllers) :)
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Nick Badal (nick@ouya.tv) from comment #5)
> In the new update, a single tap is MENU, but a double tap is HOME. (Also a
> long press is HOME on post-devkit controllers) :)
Ah, good to know, thanks. I think this patch is still good to have since there's no other way to fully exit Fennec. IIRC you have an aggressive activity killer but the Gecko process itself will continue to run in the background until it is OOM-killed.
I landed this on inbound and then belatedly realized that I was using API level 16 classes (InputManager) without the appropriate checks so I backed it out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecc5ce4b7632
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f0aec2baecc
New patch coming.
Assignee | ||
Comment 7•12 years ago
|
||
Now with proper version checks. Sorry for the churn.
Attachment #723618 -
Attachment is obsolete: true
Attachment #723873 -
Flags: review?(sriram)
Updated•12 years ago
|
Attachment #723873 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 8•12 years ago
|
||
Comment 9•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•