Closed
Bug 850132
Opened 12 years ago
Closed 12 years ago
SPS breakpad unwind (bug 779291) breaks Win64 builds with "Unsupported platform"
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: philor, Assigned: m_kato)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
There is a certain amount of truth to that error message, but it's not quite entirely true. https://tbpl.mozilla.org/php/getParsedLog.php?id=20544174&tree=Firefox https://tbpl.mozilla.org/php/getParsedLog.php?id=20544370&tree=Firefox e:\builds\moz2_slave\m-cen-w64-00000000000000000000\build\tools\profiler\PlatformMacros.h(67) : fatal error C1189: #error : "Unsupported platform"
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → m_kato
Assignee | ||
Updated•12 years ago
|
Hardware: x86 → x86_64
Assignee | ||
Comment 1•12 years ago
|
||
fix windows x64 build. also android macro should use __ANDROID__ that is pre-defined by compiler (gcc and clang).
Attachment #723831 -
Flags: review?(ted)
Comment 2•12 years ago
|
||
Comment on attachment 723831 [details] [diff] [review] fix Review of attachment 723831 [details] [diff] [review]: ----------------------------------------------------------------- I'm not really a peer on this code, but this looks ok to me. As long as it builds it should be fine. Note that bug 779291 has been backed out for now, so we'll have to land this on top of it (or fold it into the re-landing).
Attachment #723831 -
Flags: review?(ted) → review+
Comment 3•12 years ago
|
||
I folded this into the original patch and re-landed that: https://hg.mozilla.org/integration/mozilla-inbound/rev/8b366545161d
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•