Closed
Bug 850227
Opened 12 years ago
Closed 10 years ago
Progressively redraw area outside of visible area of screen
Categories
(Firefox for Android Graveyard :: Toolbar, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: jwir3, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
BenWa
:
review-
|
Details | Diff | Splinter Review |
From bug 836565:
> An issue here is that when the zoom level changes, we redraw the entire display-port
> in a single, un-cancellable transaction - this may cause a bigger delay than is
> necessary.
>
> Instead, we could redraw the visible area and progressively update the area outside
> of that afterwards, which ought to provide a faster initial update (assuming that
> update time is almost entirely drawing and the page is reasonably uniform, you're
> looking at a time reduction of ~75%). Note the comment 'Only draw progressively when
> the resolution is unchanged.' in BasicTiledThebesLayer.
This is being split out into a separate bug, since it's probably something that we want to to anyway, unrelated to reflow-on-zoom. I'm attaching the patch that was originally attached to bug 836565 and re-requesting review.
Attachment #723958 -
Flags: review?(bgirard)
Comment 1•12 years ago
|
||
Comment on attachment 723958 [details] [diff] [review]
progressive-zoom-update
Review of attachment 723958 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/basic/BasicTiledThebesLayer.cpp
@@ +633,5 @@
> // Store the old valid region, then clear it before painting.
> // We clip the old valid region to the visible region, as it only gets
> // used to decide stale content (currently valid and previously visible)
> + nsIntRegion oldValidRegion;
> + // If the resolution has changed, don't retain any old content.
// Only retain content if the resolution has not changed.
@@ +635,5 @@
> // used to decide stale content (currently valid and previously visible)
> + nsIntRegion oldValidRegion;
> + // If the resolution has changed, don't retain any old content.
> + if (mTiledBuffer.GetFrameResolution() == mPaintData.mResolution) {
> + nsIntRegion oldValidRegion = mTiledBuffer.GetValidRegion();
This oldValidRegion is shadowing oldValidRegion on line 636.
Attachment #723958 -
Flags: review?(bgirard) → review-
Comment 2•10 years ago
|
||
This isn't really valid anymore.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•