comm-central needs work performed in bug 818246 applied to it.

Conversion was performed automatically using our tried and true mach command. Review should largely be a rubber stamp.

Comment on attachment 724122 [details] [diff] [review] Part 2: Move IDLSRCS into moz.build (auto), v1 Consider this an rs+. All I did was eyeball most of the directories to see that roughly the same number of files were transferred; since it's automatic, I presume that all the spellings, etc. are safe. It also looks like you've picked up every directory in comm-central. There are few manual things that need transferring as well though.

Pretty much copied lines from m-c's rules.mk.

Conversion was done automatically. Should be a rubber stamp.

Manual conversion of the remaining XPIDL* variables to moz.build (things in conditionals). You should give this a thorough review. I haven't tested any of the patches in this bug. I'm really that lazy.

Comment on attachment 724249 [details] [diff] [review] Part 1: rules.mk update, v1 Review of attachment 724249 [details] [diff] [review]: ----------------------------------------------------------------- I'm not a c-c build config peer, so I don't feel comfortable r+'ing this. Redirecting review to other people who can hopefully r+ this before the m-c patch lands.

Comment on attachment 724251 [details] [diff] [review] Part 3: Manual conversion, v1 Review of attachment 724251 [details] [diff] [review]: ----------------------------------------------------------------- ::: ldap/xpcom/public/moz.build @@ -17,5 @@ > 'nsILDAPService.idl', > 'nsILDAPURL.idl', > ] > > -XPIDL_MODULE = 'mozldap' You dropped this line in the file. Also, as mentioned over IRC, you forgot to remove the stuff from ldap/xpcom/public/Makefile.in.

Comment on attachment 724250 [details] [diff] [review] Part 2b: Move XPIDL_MODULE and XPIDL_FLAGS, v1 I'll admit that I didn't try to compile with these patches, but I don't see anything untoward here. Although it is unusual to see such inherent Makefile syntax as -I$(topsrcdir)/ in the moz.build files, but as mozilla-central is using that syntax for its makefiles...

(In reply to Joshua Cranmer [:jcranmer] from comment #6) > I'm not a c-c build config peer, so I don't feel comfortable r+'ing this. > Redirecting review to other people who can hopefully r+ this before the m-c > patch lands. To be extra clear, all other parts on this bug I feel are also explicitly build-system reviews, not just this one. However I feel comfortable with your review on all these patches, so carry-on.

https://hg.mozilla.org/comm-central/rev/ea8f59513b2d https://hg.mozilla.org/comm-central/rev/fef8c51030cc https://hg.mozilla.org/comm-central/rev/10b5d6673cda