Closed
Bug 850558
Opened 12 years ago
Closed 11 years ago
The stack trace breadcrumbs context menu is ugly on windows.
Categories
(DevTools :: Debugger, defect, P3)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: Optimizer, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
image/png
|
Details |
The padding, boldness and border is missing.
Reporter | ||
Comment 1•12 years ago
|
||
Well, it is bold, but the difference is hard to see.
Hardware: x86_64 → All
Summary: The stack trace breadcrumbs conetxt menu is ugly on windows. → The stack trace breadcrumbs context menu is ugly on windows.
Version: unspecified → Trunk
Updated•11 years ago
|
Priority: -- → P3
Whiteboard: [good-first-bugs][lang=css][mentor=Optimizer]
Comment 2•11 years ago
|
||
I would like to take this!
Comment 3•11 years ago
|
||
(In reply to Joshua Smith [:joshua-s] from comment #2) > I would like to take this! That's wonderful, thanks!
Assignee: nobody → joshua-smith
Status: NEW → ASSIGNED
Comment 4•11 years ago
|
||
Oh no, this bug is in Windows 7. I only have XP and Mac, so it doesn't show the issue. Sorry guys :(
Updated•11 years ago
|
Assignee: joshua-smith → nobody
Hi I am interested in working on this bug,but it's my first time to work on with debug,can anybody guide me on how to get started with it?Thanks a lot.
Reporter | ||
Comment 6•11 years ago
|
||
(In reply to MikeLing from comment #5) > Hi I am interested in working on this bug,but it's my first time to work on > with debug,can anybody guide me on how to get started with it?Thanks a lot. Continuing and replying to what you were asking on IRC: You cannot use Linux/Ubuntu to fix this bug as the issue is seen only on Windows 7 (Vista may be too). So I guess you will have to use Visual Studio and all those stuff instead of your VM box :). And thus , I think you already are aware of how to build a basic Firefox build. On how to solve the issue : This will need mostly CSS changes in browser/themes/windows/devtools/debugger.css file. See http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/devtools/debugger.css#45 That is the point where the menu item CSS starts. Please ping me on IRC for further help. My nick is Optimizer.
(In reply to Girish Sharma [:Optimizer] from comment #6) > (In reply to MikeLing from comment #5) > > Hi I am interested in working on this bug,but it's my first time to work on > > with debug,can anybody guide me on how to get started with it?Thanks a lot. > > Continuing and replying to what you were asking on IRC: > > You cannot use Linux/Ubuntu to fix this bug as the issue is seen only on > Windows 7 (Vista may be too). So I guess you will have to use Visual Studio > and all those stuff instead of your VM box :). > > And thus , I think you already are aware of how to build a basic Firefox > build. > > On how to solve the issue : > > This will need mostly CSS changes in > browser/themes/windows/devtools/debugger.css file. > > See > http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/ > devtools/debugger.css#45 > > That is the point where the menu item CSS starts. > > Please ping me on IRC for further help. My nick is Optimizer. I am so appreciate about you can help and my system is window 7 actually :) .I promise I will fix the issue as soon as possible.Thanks again
Reporter | ||
Comment 8•11 years ago
|
||
Cool, assigned to you. Thank you for taking it.
Assignee: nobody → sabergeass
(In reply to Girish Sharma [:Optimizer] from comment #8) > Cool, assigned to you. Thank you for taking it. Sorry to distrub you,but I find a problem when a build source code -------------------------------------------------------------------------------------- $ python make.py Traceback (most recent call last): File "make.py", line 10, in <module> import pymake.command, pymake.process File "d:\mozilla-source\mozilla-central\build\pymake\pymake\command.py", line 14, in <module> import data, parserdata, process, util File "d:\mozilla-source\mozilla-central\build\pymake\pymake\data.py", line 6, in <module> import parserdata, parser, functions, process, util, implicit File "d:\mozilla-source\mozilla-central\build\pymake\pymake\process.py", line 7, in <module> import multiprocessing File "D:\Python27\Lib\multiprocessing\__init__.py", line 84, in <module> import _multiprocessing ImportError: DLL load failed:%1 is not a valid Win32 application -------------------------------------------------------------------------------------- but I'm sure I put the python to my PATH(my PATH was blow) what should I do? -------------------------------------------------------------------------------------- C:\mozilla-build\python;D:\Python32\python;D:\Python27;C:\mozilla-build\svn-win32-1.6.3\bin;C:\mozilla-build\wget;C:\mozilla-build\7zip\Codecs
Reporter | ||
Comment 10•11 years ago
|
||
On windows, you do not use the make.py directly. Please see the steps here :https://developer.mozilla.org/en-US/docs/Simple_Firefox_build make sure you have all the prerequisites : https://developer.mozilla.org/en-US/docs/Developer_Guide/Build_Instructions/Windows_Prerequisites
Reporter | ||
Comment 11•11 years ago
|
||
Hi MikeLing, were you able to make any progress on this bug ? Please let me know how I can help you. If you are not working on this bug, then we can free up this bug for other contributors :)
Comment 12•11 years ago
|
||
(In reply to Girish Sharma [:Optimizer] from comment #11) Please free up this bug for other contributors,Thanks a lot :)
Updated•11 years ago
|
Assignee: sabergeass → nobody
Updated•11 years ago
|
Status: ASSIGNED → NEW
Updated•11 years ago
|
Whiteboard: [good-first-bugs][lang=css][mentor=Optimizer]
Comment 14•11 years ago
|
||
Is this still true after the recent theming work? Can we close this bug?
Flags: needinfo?(scrapmachines)
Reporter | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(scrapmachines)
Resolution: --- → WORKSFORME
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•