Closed
Bug 850927
Opened 12 years ago
Closed 12 years ago
DoorHanger layout files are redundant
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: sriram, Assigned: sriram)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
There are 2 layout files for doorhangerpopup (and site_identity_popup) differing only my the width attribute. A good approach would be specify it as a theme level attribute, and use it here.
|
Assignee | |
Comment 1•12 years ago
|
||
Finally, just one layout file.
Attachment #724778 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Comment 2•12 years ago
|
||
This is a better patch.
Attachment #724787 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #724778 -
Attachment is obsolete: true
Attachment #724778 -
Flags: review?(mark.finkle)
|
||
Updated•12 years ago
|
Attachment #724787 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Backed out the whole push in https://hg.mozilla.org/integration/mozilla-inbound/rev/5eb7efc431c8 for mochitest-1 and robocop-2 errors about "Error inflating class android.widget.Button" like https://tbpl.mozilla.org/php/getParsedLog.php?id=20799813&tree=Mozilla-Inbound and https://tbpl.mozilla.org/php/getParsedLog.php?id=20798777&tree=Mozilla-Inbound
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
||
Comment 7•12 years ago
|
||
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•