Closed Bug 850927 Opened 12 years ago Closed 12 years ago

DoorHanger layout files are redundant

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: sriram, Assigned: sriram)

References

Details

Attachments

(1 file, 1 obsolete file)

There are 2 layout files for doorhangerpopup (and site_identity_popup) differing only my the width attribute. A good approach would be specify it as a theme level attribute, and use it here.
Blocks: 823644
Attached patch Patch (obsolete) (deleted) — Splinter Review
Finally, just one layout file.
Attachment #724778 - Flags: review?(mark.finkle)
Attached patch Patch (deleted) — Splinter Review
This is a better patch.
Attachment #724787 - Flags: review?(mark.finkle)
Attachment #724778 - Attachment is obsolete: true
Attachment #724778 - Flags: review?(mark.finkle)
Attachment #724787 - Flags: review?(mark.finkle) → review+
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: