Closed
Bug 850970
Opened 12 years ago
Closed 12 years ago
Adding a gain node to the graph without setting its value mutes audio
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(2 files, 2 obsolete files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
That's because we forget to send the gain parameter to the MSG, so the GainNodeEngine's mGain value will be 0, hence the audio will be muted.
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #724764 -
Flags: review?(roc)
Comment on attachment 724764 [details] [diff] [review]
Patch (v1)
Review of attachment 724764 [details] [diff] [review]:
-----------------------------------------------------------------
Wouldn't it be just as simple and slightly more efficient to default the gain to 1 in a new GainNodeEngine?
|
|
Assignee | |
Comment 4•12 years ago
|
||
Good idea.
Attachment #724764 -
Attachment is obsolete: true
Attachment #724764 -
Flags: review?(roc)
Attachment #724867 -
Flags: review?(roc)
|
|
Assignee | |
Comment 5•12 years ago
|
||
In fact, let's just remove the constructor which is going to make future similar bugs possible!
Attachment #724867 -
Attachment is obsolete: true
Attachment #724867 -
Flags: review?(roc)
Attachment #724871 -
Flags: review?(roc)
Attachment #724871 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
|
Assignee | |
Comment 8•11 years ago
|
||
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in
before you can comment on or make changes to this bug.
Description
•