I'm testing the new text prediction engine that landed in bug 838227 and I notice that it does't take into account the first latter of the word if it's typed in uppercase. See the following two example of my trying to type "hello" and "Hello". h -> his he had he -> he Henry Head hel -> held help helps hell -> hello hell held H -> the to this He -> early end each Hel -> election elected elements Hell -> elliptical ellipse ellipsoid

Shouldn't the code responsible for inserting the predicted word capitalize it if the original word typed by the user was capitalized too?

(In reply to Staś Małolepszy :stas from comment #4) > Shouldn't the code responsible for inserting the predicted word capitalize > it if the original word typed by the user was capitalized too? Yes, if the user explicitly selected it or maybe if we are at the beginning of a sentence. I don't think this should be part of the prediction engine itself. The code that inserts the word should take care of it.

(In reply to Gregor Wagner [:gwagner] from comment #5) > (In reply to Staś Małolepszy :stas from comment #4) > > Shouldn't the code responsible for inserting the predicted word capitalize > > it if the original word typed by the user was capitalized too? > > Yes, if the user explicitly selected it or maybe if we are at the beginning > of a sentence. > I don't think this should be part of the prediction engine itself. The code > that inserts the word should take care of it. I filed bug 851565.

Comment on attachment 725259 [details] [diff] [review] pull request This needs to be uplifted along with the DAG work.

Marking as blocking tef? and requesting uplift.

I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1-train git cherry-pick -x -m1 0e9009b66f21c2b92bc37ef3f096fe385c4d70de <RESOLVE MERGE CONFLICTS> git commit

tef- as bug 838227 has been also marked as tef-

Uplifted commit 0e9009b66f21c2b92bc37ef3f096fe385c4d70de as: v1-train: c00268805104809619e4fec22021db6ffb19a2d3

I guess I was not in charge of uplifting this anyway - clearing the needinfo flag!