Closed Bug 851457 Opened 12 years ago Closed 12 years ago

Parentheses wrong in Language selection list when switching to Arabic (or any RTL language)

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g18-)

VERIFIED FIXED
Tracking Status
b2g18 - ---

People

(Reporter: mihai, Unassigned)

References

Details

Attachments

(3 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:19.0) Gecko/20100101 Firefox/19.0 Build ID: 20130307023931 Steps to reproduce: Go to Settings -> Language -> Change from English (US) to Arabic in the languages list Actual results: After the language is changed, the entry for 'English (US)' becomes '(English (US' - parentheses are displayed wrong, which occurs for any language that has details in parenthesis (e.g. Brazilian Portuguese, Simplified Chinese, etc) Expected results: The label for languages that contain details in parenthesis should remain unchanged -- i.e. parentheses should not be misplaced
tracking-b2g18: --- → ?
OS: All → Gonk (Firefox OS)
This bug shows the same behavior as Bug 847739, whose proposed solution is to add a Unicode control character after the right-hand side parenthesis so that the algorithm behind bidirectional script support does not interpret the parentheses wrong in RTL languages (e.g. Arabic) -- see http://www.w3.org/International/tutorials/bidi-xhtml/#again for example of this behavior.
We're not shipping Arabic (or RTL languages) in v1 so not tracking.
This bug is a follow-up of Bug 847739, highlighting the same behavior for language selection as for FTE, but in the settings app. Lukas, Bug 847739 got tracking-b2g18:+ and was merged to gaia/master, shouldn't this bug also get the flag? Conceptually it tackles the same behavior but in a different app.
Flags: needinfo?(lsblakk)
Delphine, you confirmed Bug 847739, can you also confirm this one? Thanks!
Flags: needinfo?(lebedel.delphine)
Since markup is not allowed inside 'option' tags, the strongly-typed Unicode control characters Left-to-Right Embedding (LRE - U+202A), Right-to-Left Embedding (RLE - U+202B) and Pop Directional Formatting (PDF - U+202C) where used to wrap the language labels.
Attachment #731561 - Flags: review?(kaze)
Attachment #731561 - Attachment mime type: text/plain → text/html
Comment on attachment 731561 [details] Pull Request #8899 - Enforce correct script direction Looks good to me, thanks Mihai! https://github.com/mozilla-b2g/gaia/commit/31389626cc33c98b80b71f6765144f2be0fe3462
Attachment #731561 - Flags: review?(kaze) → review+
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Flags: needinfo?(lsblakk)
Flags: needinfo?(lebedel.delphine)
Resolution: --- → FIXED
Sorry I'm in perou for a MeetUp, didn't get to catch this one on time!
According to the STR in comment 0, this issue is verified pass on latest flame 2.2&3.0 and N5 2.2&3.0 build, Parentheses are displayed correctly and the label for languages that contain details in parenthesis remain unchanged. See attachment:Verify1_Flame 2.2&3.0_N5 2.2&3.0_Pass.png. Reproducing rate:0/10 Device:Flame 2.2 build (Pass) Build ID 20150525162504 Gaia Revision 144673a413586f98b5e2c27b781c1a539611f754 Gaia Date 2015-05-25 02:01:14 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/115112d51e08 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150525.202102 Firmware Date Mon May 25 20:21:12 EDT 2015 Bootloader L1TC000118D0 Device:Flame 3.0 build (Pass) Build ID 20150525160205 Gaia Revision 5bcc08a732163087999251b523e3643db397412c Gaia Date 2015-05-24 14:44:40 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/b6623a27fa64 Gecko Version 41.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150525.192755 Firmware Date Mon May 25 19:28:07 EDT 2015 Bootloader L1TC000118D0 Device:Nexus 5 2.2 build (Pass) Build ID 20150525002504 Gaia Revision 144673a413586f98b5e2c27b781c1a539611f754 Gaia Date 2015-05-25 02:01:14 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c4db2af40b1b Gecko Version 37.0 Device Name hammerhead Firmware(Release) 5.1 Firmware(Incremental) eng.cltbld.20150525.041303 Firmware Date Mon May 25 04:13:19 EDT 2015 Bootloader HHZ12f Device: Nexus 5 3.0 build (Pass) Build ID 20150525160205 Gaia Revision 5bcc08a732163087999251b523e3643db397412c Gaia Date 2015-05-24 14:44:40 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/b6623a27fa64 Gecko Version 41.0a1 Device Name hammerhead Firmware(Release) 5.1 Firmware(Incremental) eng.cltbld.20150525.192207 Firmware Date Mon May 25 19:22:24 EDT 2015 Bootloader HHZ12f
Status: RESOLVED → VERIFIED
QA Whiteboard: [MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: