Closed
Bug 851949
Opened 11 years ago
Closed 11 years ago
Avoid setting AudioParam values needlessly
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
One optimization which we can do for AudioParam is to make sure that SetValue() calls that do not result in the value being changed at all will become no-ops, in order to avoid the overhead of sending the same value to the MSG thread again, which is pointless anyway.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #725920 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/019dfc114d05
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/019dfc114d05
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
|
Assignee | |
Comment 4•11 years ago
|
||
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in
before you can comment on or make changes to this bug.
Description
•