Closed Bug 851966 Opened 12 years ago Closed 12 years ago

StreamBuffer::ForgetUpTo is horribly inefficient

Categories

(Core :: Web Audio, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(2 files)

Attached image Profile (deleted) —
In a profile that I have with a lot of Web Audio buffer source nodes playing, we can spend about 50% of the total time in MSGImpl::UpdateCurrentTime, with a 30% of the total time in StreamBuffer::ForgetUpTo.
Attached patch Patch (v1) (deleted) — Splinter Review
I had to store the enum on MediaStreamGraph in order to avoid an #include hell which resulted in trying to store it on AudioNodeStream. :(
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #725953 - Flags: review?(roc)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: