Jonathan Griffin (:jgriffin) Assignee
	Description • 11 years ago

We catch errors reported to window.onerror during async execute calls, but don't report the line number:

510   originalOnError = curWindow.onerror;
511   curWindow.onerror = function errHandler(errMsg, url, line) {
512     sandbox.asyncComplete(errMsg, 17, null, asyncTestCommandId);
513     curWindow.onerror = originalOnError;
514   };

We should be reporting as much of the stack trace as we can get.

	Jonathan Griffin (:jgriffin) Assignee
	Comment 1 • 11 years ago

This seems like the right thing to do, although as I mentioned, I couldn't actually write a test for this.

	Malini Das [:mdas] - Away, not checking bugmail
	Comment 2 • 11 years ago

Comment on attachment 731971 [details] [diff] [review]
Use the url and line number passed to window.onerror,

Review of attachment 731971 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm, I couldn't figure one out either, but if there is a way to catch it, then this is what we should return.

	Jonathan Griffin (:jgriffin) Assignee
	Comment 3 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d77d2aaabf9

	Phil Ringnalda (:philor)
	Comment 4 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/1d77d2aaabf9

	Malini Das [:mdas] - Away, not checking bugmail
	Comment 5 • 11 years ago

https://hg.mozilla.org/releases/mozilla-b2g18/rev/8565e79f6e54

	Jonathan Griffin (:jgriffin) Assignee
	Comment 6 • 11 years ago

(In reply to Malini Das [:mdas] from comment #5)
> https://hg.mozilla.org/releases/mozilla-b2g18/rev/8565e79f6e54

thanks, you beat me to it!

	Jonathan Griffin (:jgriffin) Assignee
	Comment 7 • 11 years ago

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/b8359be6a074