Closed
Bug 853483
Opened 12 years ago
Closed 11 years ago
Triage report times out on Firefox (Any) query
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: lizzard, Assigned: glob)
References
()
Details
Attachments
(1 file)
(deleted),
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
At https://bugzilla.mozilla.org/page.cgi?id=triage_reports.html , when I request the Firefox report for _Any_ , where the last commenter is the reporter, the query fails with the message, "Service Unavailable. The service is temporarily unavailable. Please try again later."
Narrower queries still work.
the problem here is the amount of bugs it has to process is too large, causing a timeout in the load balancer. to address this i've set an upper-limit on the number of bugs.
i also took the opportunity to do some long-overdue refactoring of the custom reports by breaking out each set of reports into their own files.
Attachment #728991 -
Flags: review?(dkl)
Comment 2•11 years ago
|
||
Comment on attachment 728991 [details] [diff] [review]
patch v1
Review of attachment 728991 [details] [diff] [review]:
-----------------------------------------------------------------
Just minor stuff. Otherwise the reports worked fine for me and the new error message worked as well. r=dkl
::: extensions/BMO/template/en/default/pages/email_queue.html.tmpl
@@ +47,4 @@
> [% END %]
> </td>
> <td>
> + [% job.subject ? job.subject : '-' FILTER html %]
s/subject/error_message/
@@ +52,5 @@
> </tr>
> + [% IF job.subject %]
> + <tr class="report item [% loop.count % 2 == 1 ? "report_row_odd" : "report_row_even" %]">
> + <td colspan="3"> </td>
> + <td colspan="3">[% job.subject FILTER html %]</td>
I feel this would look better if you used the entire row for the subject. For example:
<td colspan="6">Subject: [% job.subject FILTER html %]</td>
Attachment #728991 -
Flags: review?(dkl) → review+
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/BMO/Extension.pm
added extensions/BMO/lib/Reports
missing extensions/BMO/lib/Reports.pm
deleted extensions/BMO/lib/Reports.pm
added extensions/BMO/lib/Util.pm
added extensions/BMO/lib/Reports/EmailQueue.pm
added extensions/BMO/lib/Reports/Groups.pm
added extensions/BMO/lib/Reports/ReleaseTracking.pm
added extensions/BMO/lib/Reports/Triage.pm
added extensions/BMO/lib/Reports/UserActivity.pm
modified extensions/BMO/template/en/default/hook/global/user-error-errors.html.tmpl
modified extensions/BMO/template/en/default/pages/email_queue.html.tmpl
Committed revision 8756.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•