Closed
Bug 853723
Opened 12 years ago
Closed 12 years ago
Settings launches 100 ms slower after landing multi-resolution fix
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rexboy, Assigned: rexboy)
Details
Attachments
(1 file)
This is a follow-up bug of bug 830644.
Settings app launches about 100ms slower after landing settings part of multi-resolution fix. It needs 1 second to launch now. See: https://datazilla.mozilla.org/b2g/?branch=master&range=7&test=startup_time&app=settings&app_list=settings&gaia_rev=7202403530d43a3f&gecko_rev=ce5c0b8f9aebdc65
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → rexboy
|
|
Assignee | |
Comment 1•12 years ago
|
||
This may because responsive.css is attached at bottom of <head>, whwre javascript files is already started to load. also it didn't specify type="text/css". Seems it's faster if I move it up together with other css files (down to 950ms on my phone, very similar to previous commit). Bbut I'm not sure if other reasons exists. All other css changes seems to be safe because most of them apply to lazy-loaded elements when settings app starts.
|
||
Comment 2•12 years ago
|
||
From bug 830644 comment 129:
> I believe https://github.com/mozilla-b2g/gaia/commit/0f3a6c729085e322502c05b5dc932bf27ea0139c or https://github.com/mozilla-b2g/gaia/commit/8f5ebdd30c0a41c2fc9e78a3336c7a148d36b35a caused a 100+ ms performance regression on startup of the Settings app. It's now above 1s.
|
|
||
Comment 3•12 years ago
|
||
(In reply to KM Lee [:rexboy] from comment #1)
> This may because responsive.css is attached at bottom of <head>, whwre
> javascript files is already started to load.
I see a good improvement here too when moving the CSS up. Can you try to land that then? Also, could you check all other changes of bug 830644 to check that the new responsive CSS is included above JS files?
|
|
Assignee | |
Comment 4•12 years ago
|
||
Let's try it. Evelyn may you help review it?
Attachment #729389 -
Flags: review?(ehung)
|
|
Assignee | |
Comment 5•12 years ago
|
||
(In reply to Anthony Ricaud (:rik) from comment #3)
> (In reply to KM Lee [:rexboy] from comment #1)
> I see a good improvement here too when moving the CSS up. Can you try to
> land that then? Also, could you check all other changes of bug 830644 to
> check that the new responsive CSS is included above JS files?
Thanks for confirming, I will do double check other PRs inside 830644 then.
Some of them already attaches responsive.css at top.
|
|
||
Comment 6•12 years ago
|
||
Comment on attachment 729389 [details]
PATCH
Steeling review to get this landing. Hope you don't mind Evelyn.
Attachment #729389 -
Flags: review?(ehung) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/3b94786c301c353f1336d8574bfce2d38fb8cfe7
Landed, thank you Rik. Let's wait for performance being measured:
https://datazilla.mozilla.org/b2g/?branch=master&range=7&test=startup_time&app_list=settings&app=settings
|
|
Assignee | |
Comment 8•12 years ago
|
||
Seems it works. Startup time now go back to less than 950ms. Closing the bug.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•