Patch incoming.

This lets a --enable-gtest build to finish on Android-x86 for me - I've done no further testing yet.

Comment on attachment 728226 [details] [diff] [review] Allow --enable-gtest on Android and fix build issues bas for moz2d tests.

Comment on attachment 728226 [details] [diff] [review] Allow --enable-gtest on Android and fix build issues Review of attachment 728226 [details] [diff] [review]: ----------------------------------------------------------------- This comment applies for all places! :-) ::: gfx/2d/unittest/TestScaling.cpp @@ +22,5 @@ > > void > TestScaling::BasicHalfScale() > { > + uint32_t *pixels = new uint32_t[500*500]; Don't do this :-) @@ +31,5 @@ > pixels[(y + 1) * 500 + x] = 0xff000000; > pixels[(y + 1) * 500 + x + 1] = 0xff0000ff; > } > } > + ImageHalfScaler scaler(reinterpret_cast<uint8_t*>(pixels), 500 * 4, IntSize(500, 500)); &data.front()

Got time to finish this cwiiis? I'm looking into getting this to run on buildbot to give mobile some APZC tests.

Comment on attachment 741975 [details] [diff] [review] Allow --enable-gtest on Android and fix build issues v2 Review of attachment 741975 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/2d/unittest/TestScaling.cpp @@ +25,5 @@ > { > std::vector<uint8_t> data; > data.resize(500 * 500 * 4); > > + uint32_t *pixels = (uint32_t*)&data.front(); C++ casts, please.

author credits go to Cwiiis: https://hg.mozilla.org/integration/mozilla-inbound/rev/5fb2a77bb0db