Closed
Bug 853910
Opened 12 years ago
Closed 12 years ago
Stop using prclist in the workers EventListenerManager
Categories
(Core :: DOM: Workers, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
It's doing evil warning things to me.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #728302 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #728303 -
Flags: review?(khuey)
(In reply to Boris Zbarsky (:bz) from comment #0)
> It's doing evil warning things to me.
Evil? Like what?
|
|
Assignee | |
Comment 4•12 years ago
|
||
Every single use of PR_CLIST_IS_EMPTY triggers a warning about extra parens around an equality comparison, and since this header is included from pretty much every single WebIDL binding file building in dom/bindings leads to many warnings that completely hide other warnings and compiler errors.
|
|
Assignee | |
Comment 5•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=8635785856b8 looks greenish, fwiw.
Attachment #728302 -
Flags: review?(khuey) → review+
Attachment #728303 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/86253d3b7fac
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b8b0c20f8ba
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla22
|
||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/86253d3b7fac
https://hg.mozilla.org/mozilla-central/rev/1b8b0c20f8ba
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•