Open
Bug 853954
Opened 12 years ago
Updated 2 years ago
Properly test config environment in test_base.py
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
NEW
People
(Reporter: gps, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
I'm hacking around build bot test failures to land bug 648681. This bug tracks getting proper testing of .config_environment in test_base.py by stubbing out a config.status or something.
Reporter | ||
Comment 1•12 years ago
|
||
I just disabled a few tests in test_base.py because of this OS X bustage:
make -C python check
TEST-UNEXPECTED-FAIL | /builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/test/test_base.py | line 63, test_config_environment: Evaluation of your mozconfig exited with an error. This could be triggered
by a command inside your mozconfig failing. Please change your mozconfig
to not error and/or to catch errors in executed commands.
TEST-PASS | /builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/test/test_base.py | test_config_guess
TEST-UNEXPECTED-FAIL | /builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/test/test_base.py | line 92, test_get_binary_path: Evaluation of your mozconfig exited with an error. This could be triggered
by a command inside your mozconfig failing. Please change your mozconfig
to not error and/or to catch errors in executed commands.
TEST-PASS | /builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/test/test_base.py | test_objdir_config_guess
TEST-PASS | /builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/test/test_base.py | test_path_argument
ERROR: test_config_environment (__main__.TestMozbuildObject)
Traceback (most recent call last):
File "/builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/test/test_base.py", line 63, in test_config_environment
config_status = os.path.join(base.topobjdir, 'config.status')
File "/builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/base.py", line 60, in topobjdir
topobj = self.mozconfig['topobjdir'] or 'obj-@CONFIG_GUESS@'
File "/builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/base.py", line 73, in mozconfig
self._mozconfig = loader.read_mozconfig()
File "/builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/mozconfig.py", line 195, in read_mozconfig
raise MozconfigLoadException(path, MOZCONFIG_BAD_EXIT_CODE, lines)
MozconfigLoadException: Evaluation of your mozconfig exited with an error. This could be triggered
by a command inside your mozconfig failing. Please change your mozconfig
to not error and/or to catch errors in executed commands.
ERROR: test_get_binary_path (__main__.TestMozbuildObject)
Traceback (most recent call last):
File "/builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/test/test_base.py", line 92, in test_get_binary_path
base.topobjdir, substs=substs)
File "/builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/base.py", line 60, in topobjdir
topobj = self.mozconfig['topobjdir'] or 'obj-@CONFIG_GUESS@'
File "/builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/base.py", line 73, in mozconfig
self._mozconfig = loader.read_mozconfig()
File "/builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/mozconfig.py", line 195, in read_mozconfig
raise MozconfigLoadException(path, MOZCONFIG_BAD_EXIT_CODE, lines)
MozconfigLoadException: Evaluation of your mozconfig exited with an error. This could be triggered
by a command inside your mozconfig failing. Please change your mozconfig
to not error and/or to catch errors in executed commands.
make[1]: *** [run-/builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/test/test_base.py] Error 1
TEST-PASS | /builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/test/test_containers.py | test_dict_defaults
TEST-PASS | /builds/slave/m-in-osx64-0000000000000000000/build/python/mozbuild/mozbuild/test/test_containers.py | test_global_default
Reporter | ||
Comment 2•11 years ago
|
||
Crossing my fingers...
https://tbpl.mozilla.org/?tree=Try&rev=b710f308419d
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → gps
Status: NEW → ASSIGNED
Reporter | ||
Updated•10 years ago
|
Assignee: gps → nobody
Status: ASSIGNED → NEW
Updated•7 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•