Closed Bug 854057 Opened 12 years ago Closed 12 years ago

"mach build" thinks it failed when it didn't, with "Exception: Binary expected at $OBJDIR/dist/firefox does not exist"

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: dholbert, Assigned: gps)

References

Details

Attachments

(1 file)

Starting this afternoon, my m-i "./mach build" ends with: { 6:37.74 613 compiler warnings present. Your build was successful! Error running mach: ['build'] The error occured in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: Exception: Binary expected at /scratch/work/builds/mozilla-inbound/mozilla/../obj/dist/firefox does not exist. File "/scratch/work/builds/mozilla-inbound/mozilla/python/mozbuild/mozbuild/mach_commands.py", line 131, in build app_path = self.get_binary_path('app') File "/scratch/work/builds/mozilla-inbound/mozilla/python/mozbuild/mozbuild/base.py", line 157, in get_binary_path raise Exception('Binary expected at %s does not exist.' % path) } I clobbered my objdir and rebuilt, and I got the same result. And if I then immediately repeat "./mach build" without changing anything (nothing to compile), I get the same result again. So -- basically, this is happening 100% of the time for me, when I build w/ mach. Note that it's looking for "dist/firefox" there -- not dist/bin/firefox. The former doesn't exist (and never has, AFAIK). The latter does exist and works fine. I'm building from this cset, which seemed to do fine on tbpl: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=d89e6ebf2a7b so it might be something specific to my machine (or alternately, tbpl might have some magic sauce that prevents them from hitting this).
Attached file my mozconfig file (deleted) —
Here's my mozconfig file, for reference. The sourced "~/.mozconfig_localMachine" just has the following two lines: mk_add_options MOZ_MAKE_FLAGS='-s -j8' ac_add_options --with-ccache=/usr/bin/ccache
(I'm on Ubuntu 12.10, using gcc/g++ version 4.7.2, with ccache)
This is a regression from bug 648681. It sure looks like I forgot a 'bin' directory at https://hg.mozilla.org/integration/mozilla-inbound/file/f8613cef1d54/python/mozbuild/mozbuild/base.py#l140. Derp. This is certainly tempting to land without review...
Depends on: 648681
I self-reviewed this trivial patch because it will annoy a lot of people if it isn't fixed and it's Saturday and nobody is around. https://hg.mozilla.org/integration/mozilla-inbound/rev/2fc0356e6949
Assignee: nobody → gps
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla22
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Component: Build Config → mach
OS: Linux → All
Hardware: x86_64 → All
When building Firefox for Android from mozilla-central, I still get the following mach error: The details of the failure are as follows: Exception: Binary expected at /Users/cpeterson/Code/mozilla/central/objdir-android/dist/bin/fennec does not exist. File "/Users/cpeterson/Code/mozilla/central/python/mozbuild/mozbuild/mach_commands.py", line 131, in build app_path = self.get_binary_path('app') File "/Users/cpeterson/Code/mozilla/central/python/mozbuild/mozbuild/base.py", line 159, in get_binary_path raise Exception('Binary expected at %s does not exist.' % path)
Depends on: 854545
(In reply to Joe Drew (:JOEDREW! \o/) from comment #6) > https://hg.mozilla.org/mozilla-central/rev/2fc0356e6949 This doesn't appear to fix the issue for me. I followed the instructions for cloning the codebase here: https://developer.mozilla.org/en-US/docs/Simple_Thunderbird_build Here is the error message I get: Your build was successful! Error running mach: ['build'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: Exception: Binary expected at /Users/damon/hg/mozilla/comm-central/obj-x86_64-apple-darwin12.4.0/dist/Daily.app/Contents/MacOS/thunderbird does not exist. File "/Users/damon/hg/mozilla/comm-central/mozilla/python/mozbuild/mozbuild/mach_commands.py", line 348, in build app_path = self.get_binary_path('app') File "/Users/damon/hg/mozilla/comm-central/mozilla/python/mozbuild/mozbuild/base.py", line 279, in get_binary_path raise Exception('Binary expected at %s does not exist.' % path)
Please file a new bug under Thunderbird product. (FYI I saw this bug either.)
FYI, The bug for Thunderbird (comment 8) is bug 863409
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: