Closed
Bug 854320
Opened 12 years ago
Closed 11 years ago
ECMA-402 tests ch10/10.1/10.1.1_a.js, ch11/11.1/11.1.1_a.js, ch12/12.1/12.1.1_a.js failing
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: mozillabugs, Assigned: mozillabugs)
References
()
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mozillabugs
:
review+
RyanVM
:
checkin+
|
Details | Diff | Splinter Review |
Tests ch10/10.1/10.1.1_a.js, ch11/11.1/11.1.1_a.js, ch12/12.1/12.1.1_a.js of the conformance test suite for standard ECMA-402, ECMAScript Internationalization API, fail when run against the implementation currently being landed.
The Intl.Collator, Intl.NumberFormat, and Intl.DateTimeFormat constructors modify properties of the RegExp constructor.
The failure occurs because the use of RegExp in self-hosted code can be observed through RegExp statics due to bug 834989.
Assignee | ||
Comment 1•11 years ago
|
||
Use the new intrinsics introduced by the fix for bug 834989.
Assignee: general → mozillabugs
Status: NEW → ASSIGNED
Attachment #769979 -
Flags: review?(jwalden+bmo)
Comment 2•11 years ago
|
||
Comment on attachment 769979 [details] [diff] [review]
Bug 854320 - ECMA-402 tests ch10/10.1/10.1.1_a.js, ch11/11.1/11.1.1_a.js, ch12/12.1/12.1.1_a.js failing
Review of attachment 769979 [details] [diff] [review]:
-----------------------------------------------------------------
Great!
::: js/src/builtin/Intl.js
@@ +71,5 @@
> +
> +/**
> + * Removes Unicode locale extension sequences from the given language tag.
> + */
> +function removeExtensions(locale) {
Let's name this a little more precisely: removeUnicodeExtensions. (I'd even go for removeUnicodeLocaleExtensions, myself, but that's getting long enough for length to start actually mattering, I think. :-) )
Attachment #769979 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Updated per comment 2. Carrying r+jwalden.
Please check in after the fix for bug 834989.
Attachment #769979 -
Attachment is obsolete: true
Attachment #773360 -
Flags: review+
Attachment #773360 -
Flags: checkin?(jwalden+bmo)
Comment 4•11 years ago
|
||
Comment on attachment 773360 [details] [diff] [review]
Bug 854320 - ECMA-402 tests ch10/10.1/10.1.1_a.js, ch11/11.1/11.1.1_a.js, ch12/12.1/12.1.1_a.js failing
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b37ab9448ed
Attachment #773360 -
Flags: checkin?(jwalden+bmo) → checkin+
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•