Closed Bug 854413 Opened 12 years ago Closed 12 years ago

[MMS][SMS] Move all DOM element property initialization into init methods and rationalize variable names and ids

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18+ fixed)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
b2g18 + fixed

People

(Reporter: rwaldron, Assigned: rwaldron)

References

Details

Attachments

(1 file)

Fix for 854413
(deleted), text/x-github-pull-request
julienw
: review+
akeybl
: approval-gaia-v1+
Details
removes "lazy" accessor code
Attached file Fix for 854413 (deleted) —
Attachment #730323 - Flags: review?(felash)
Comment on attachment 730323 [details] Fix for 854413 r=me please change the commit title to reflect the new bug title too.
Attachment #730323 - Flags: review?(felash) → review+
Summary: [MMS][SMS] Move all DOM element property initialization into init methods → [MMS][SMS] Move all DOM element property initialization into init methods and rationalize variable names and ids
Keywords: checkin-needed
Comment on attachment 730323 [details] Fix for 854413 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): - User impact if declined: we'll need this to be able to uplift other sms patches Testing completed: yes Risk to taking this patch (and alternatives if risky): medium, but lots of testing has been done String or UUID changes made by this patch: none
Attachment #730323 - Flags: approval-gaia-v1?(21)
master: 5a45368a71fc0569bf4adaf8cbf03d4062c6b756
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Triage would like Vivien to weigh in on comment #3 when he has the time.
tracking-b2g18: ? → +
Flags: needinfo?(21)
Argh! Without any other patch to uplift that depends on this one I don't think we should uplift it. That sounds like a cleanup patch which is good but it does not seems to bring anything else :(
Flags: needinfo?(21)
We will have other patches to uplift though...
Comment on attachment 730323 [details] Fix for 854413 When we need this patch let's uplift this, but not prior.
Attachment #730323 - Flags: approval-gaia-v1?(21) → approval-gaia-v1-
This patch will block all SMS/MMS patches to come.
To me, this is wrong to not take it now as per comment 9 it will be uplifted anyway, and if this is risky, then it's better to uplift it earlier than later to catch regressions. But hey we can also wait a few more days.
Flags: needinfo?(akeybl)
Comment on attachment 730323 [details] Fix for 854413 blocks the uplifts for Bug 853788 and Bug 854494, so requesting again.
Attachment #730323 - Flags: approval-gaia-v1- → approval-gaia-v1?(21)
Sent email to clarify the risk/reward, will follow up in bug.
Flags: needinfo?(akeybl)
Also blocks the uplift of bug 852387
Ok, managed to land 852387, so forget my last comment :)
After talking with Julian, we'll uplift this in support of bug 853788 (missed feature complete by just a few day). Julien suggests testing around "receiving Sms, sending Sms, looking up a contact, sending a SMS from the Contact app, deleting SMS, deleting threads". jsmith - needinfo on you to help get this once prioritized in QA too.
Flags: needinfo?(jsmith)
Keywords: verifyme
Paul - Can you look into this?
Flags: needinfo?(jsmith) → needinfo?(pyang)
Attachment #730323 - Flags: approval-gaia-v1?(21) → approval-gaia-v1+
v1-train: d4946c9fd62f2e7cd9e6c66c92fd211a6fe18631
status-b2g18: --- → fixed
Gaia: 7ea7918013a012ddf04a1324592b898530488178 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6a187d801193 BuildID 20130423070204 Version 18.0 Verified, all basic sms cases work successfully.
Status: RESOLVED → VERIFIED
Flags: needinfo?(pyang)
Attachment mime type: text/plain → text/x-github-pull-request
Removing Verifyme tag due to comment 18.
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: