Closed Bug 854478 Opened 12 years ago Closed 11 years ago

drop support for converting files in the profile directory from Sherlock

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 24

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

Since forever ago, we save files in an XML format, and we've converted any existing Sherlock (.src) files in the profile directory to that format. Since there's been no way to create these files in the profile since Firefox 2, we should be able to stop supporting Sherlock files dropped into the profile.
Attached patch patch (deleted) — Splinter Review
This is step 1 to removing support for the Sherlock format entirely. This patch just avoids the conversion, but still loads the plugins, so it's pretty simple code removal. I think I'll do the rest of the work in two steps: 1) stop supporting loading Sherlock files from disk entirely 2) stop supporting installation of Sherlock file from the web
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #737760 - Flags: review?(mnoorenberghe+bmo)
Comment on attachment 737760 [details] [diff] [review] patch Review of attachment 737760 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay.
Attachment #737760 - Flags: review?(mnoorenberghe+bmo) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Tetsuharu: which dev-docs do you think need updating? This doesn't have much impact on developers or users, as far as I can tell.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: