Closed
Bug 854927
Opened 12 years ago
Closed 12 years ago
Remove callback from new async getCharsetForURI in PlacesUtils
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: raymondlee, Assigned: raymondlee)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
|
Assignee | |
Updated•12 years ago
|
Summary: Remove callback from getCharsetForURI in PlacesUtils → Remove callback from new async getCharsetForURI in PlacesUtils
|
|
Assignee | |
Comment 1•12 years ago
|
||
Remove the callback from the new async getChaersetForURI, since we can use the promise as getCharsetForURI(...).then(callback)
|
|
Assignee | |
Comment 2•12 years ago
|
||
http://mxr.mozilla.org/mozilla-central/ident?i=getCharsetForURI doesn't show any callers are using the second argument so it's safe to remove that.
Attachment #729998 -
Flags: review?(mak77)
|
|
Assignee | |
Updated•12 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 3•12 years ago
|
||
Comment on attachment 729998 [details] [diff] [review]
v1
Review of attachment 729998 [details] [diff] [review]:
-----------------------------------------------------------------
yep, sorry for the double change here, my fault.
We never need to provide both a promise and a callback hook, since the promise can do callbacks.
Attachment #729998 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attachment #729998 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 5•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•