Daniel Holbert [:dholbert] Reporter
	Description • 12 years ago

The files local_debug_info_symbolizer.cc, local_debug_info_symbolizer.h, shim_mac_dump_syms.h, and shim_mac_dump_syms.mm were checked in without any license block, in this changeset:
  https://hg.mozilla.org/mozilla-central/rev/cc45fdc389df#l11.1

I'm assuming this was just an oversight and they should all be MPL licensed like the other new files in that commit (as long as they weren't taken from another project, in which case I think we'd need to include the other project's license header, though IANAL).

jseward, can you comment on whether these should just have an MPL block?

	Benoit Girard (:BenWa)
	Comment 1 • 12 years ago

That's just a oversight. It's mozilla code. I saw it but forgot to point it out in the review.

	Julian Seward [:jseward] Assignee
	Comment 2 • 12 years ago

I wrote shim_mac_dump_syms.{mm,h} so they're MPLable.
local_debug_info_symbolizer.{cc,h} came from Ted, and I'm not
clear if they are new or derivatives of existing bits of
breakpad.  Ted?

	(not currently active) Ted Mielczarek
	Comment 3 • 12 years ago

They're original code I wrote, so MPL is fine. Sorry about that.

	Daniel Holbert [:dholbert] Reporter
	Comment 5 • 12 years ago

Comment on attachment 730160 [details] [diff] [review]
Patch

Thanks!

	Julian Seward [:jseward] Assignee
	Comment 6 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/52cd656def30

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/52cd656def30