Closed
Bug 855365
Opened 12 years ago
Closed 8 years ago
Focusing tabs in the awesome screen doesn't work properly
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
(deleted),
patch
|
sriram
:
review+
kats
:
checkin+
|
Details | Diff | Splinter Review |
See http://people.mozilla.com/~kgupta/tmp/awesome.png
Also if we get the visual kinks worked out, each of the tabs will need separate "selected" and "focused" states, so that you can switch focus to a different tab without selecting it, and then press the enter/action button to select it. Upon selection, the viewpager below should update to reflect the desired tab content.
I have a patch that removes focusability from the tab widget entirely, which also fixes this problem by preventing it from happening in the first place. It's still possible to switch tabs by going left/right with focus in the viewpager, so I think this is an acceptable fallback if we can't get it working perfectly.
Assignee | ||
Comment 1•12 years ago
|
||
Comment on attachment 730235 [details] [diff] [review]
Remove focus
I'd like to land this for now. It can be backed out/undone once we have proper focus support for the tab widget.
Attachment #730235 -
Flags: review?(sriram)
Updated•12 years ago
|
Attachment #730235 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e15f135411f9
Marking as leave open so that we can continue working on proper focus support in this bug.
Whiteboard: [leave open]
Assignee | ||
Updated•12 years ago
|
Attachment #730235 -
Flags: checkin+
Comment 3•12 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Assignee: sriram.mozilla → bugmail
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•