Closed Bug 855502 Opened 12 years ago Closed 12 years ago

we need a proper design for the new checkboxes

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox22 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 23
Tracking Flags:
Tracking Status
firefox22 --- verified

People

(Reporter: paul, Assigned: miker)

References

Details

Attachments

(2 files, 2 obsolete files)

Switch to using images ... no more crosses.
(deleted), patch
bbenvie
: review+
lsblakk
: approval-mozilla-beta+
Details | Diff | Splinter Review
Screenshot of the patched version
(deleted), image/png
Details
The crosses are not that great.
Attached image Proposed checkbox (obsolete) (deleted) —
Maybe we can use the checkbox present in the timeline of events...
(In reply to scheco from comment #1) > Created attachment 730743 [details] > Proposed checkbox > > Maybe we can use the checkbox present in the timeline of events... In dark theme, maybe yes. They are taken from the initial dark theme mockups of shorlander after all.
Attached image Rudimentary mockup. (obsolete) (deleted) —
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
The crosses looked bad and were not visible on Windows 7 (bug 859686) so I have switched to using images. The dark themed one is from Shorlander's mockup and I made the light one. The light one should probably be redesigned by shorlander but please disregard that for the purposes of the review.
Attachment #736316 - Flags: review?(bbenvie)
Attachment #736316 - Flags: feedback?(shorlander)
Attached image Screenshot of the patched version (deleted) —
Already tested across OSes.
Attachment #730743 - Attachment is obsolete: true
Attachment #730781 - Attachment is obsolete: true
Comment on attachment 736316 [details] [diff] [review] Switch to using images ... no more crosses. Review of attachment 736316 [details] [diff] [review]: ----------------------------------------------------------------- lgtm!
Attachment #736316 - Flags: review?(bbenvie) → review+
Because this is an important issue on Windows 7 we may as well land it as it is.
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/630fa3185e7e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Comment on attachment 736316 [details] [diff] [review] Switch to using images ... no more crosses. [Approval Request Comment] Bug caused by (feature/regressing bug #): 859686 User impact if declined: Checkboxes will not be visible on Windows 7 Testing completed (on m-c, etc.): Yes Risk to taking this patch (and alternatives if risky): No risk, purely cosmetic String or IDL/UUID changes made by this patch: None
Attachment #736316 - Flags: approval-mozilla-beta?
Comment on attachment 736316 [details] [diff] [review] Switch to using images ... no more crosses. Approving for FF22, and pinging shorlander to make sure there aren't any concerns with this shipping in FF22 due to bug 859686.
Comment on attachment 736316 [details] [diff] [review] Switch to using images ... no more crosses. adding the plus that got left off of akeybl's pass-through
Attachment #736316 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on Firefox 22 Beta 6 (Build ID: 20130617145905) on Windows 7, Windows 8, Ubuntu and Mac OS X. User Agents: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0 Mozilla/5.0 (Windows NT 6.2; rv:22.0) Gecko/20100101 Firefox/22.0 Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20100101 Firefox/22.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:22.0) Gecko/20100101 Firefox/22.0
Status: RESOLVED → VERIFIED
status-firefox22: fixed → verified
Attachment #736316 - Flags: feedback?(shorlander)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: