Kamil Jozwiak [:kjozwiak] Reporter
	Description • 11 years ago

When creating a new tab using the "+" from a website that is currently bookmarked, the "Bookmark Star" will not update in the app bar and appear as enabled on the new tab that was just created.

Steps to reproduce the issue:

1) Open Firefox Metro
2) Go to stackoverflow.com and bookmark the website using the "Star" in the app bar
3) Once bookmarked, select the "+" to create a new tab
4) You will notice that the "Bookmark Star" is enabled on the new tab

Current Behavior:

- When opening a new tab from a bookmarked page, the app bar is not refreshed and the new tab appears as bookmarked because the "Star" was not cleared

Expected Behavior:

- When opening a new tab from a website that is bookmarked, the app bar should be refreshed in the new tab being created

	Kamil Jozwiak [:kjozwiak] Reporter
	Comment 1 • 11 years ago

it5 consideration?

	Marco Mucci [:MarcoM]
	Comment 2 • 11 years ago

Moving to iteration #5 for consideration as a defect story.

	Brian R. Bondy [:bbondy] Assignee
	Comment 3 • 11 years ago

Looks like we just never refresh the appbar on the start page, so it stays in its last state.

	Brian R. Bondy [:bbondy] Assignee
	Comment 4 • 11 years ago

The problem is that on the start screen the context UI showing stuff doesn't really make sense because it's always partially showing. It's better to treat the appbar with its own events and act on those events when the appbar is actually showing.  Added appbar dismissing just for symmetry.

	Sam Foster [:sfoster] (he/him)
	Comment 5 • 11 years ago

Comment on attachment 731035 [details] [diff] [review]
Patch v1.

Review of attachment 731035 [details] [diff] [review]:
-----------------------------------------------------------------

I like the showing/dismissing events - should clean up a lot of inferred state. Tested it out solo and also put the MozAppbarDismissing event to use in one of my patches and works well for me. 
I can imagine a situation where we might want to cancel the dimissing events and prevent the appbar from hiding, but until it comes along I think this is good as-is.

	Brian R. Bondy [:bbondy] Assignee
	Comment 6 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0b57faff59d

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/c0b57faff59d

	raymond [:retornam] (inactive)
	Comment 8 • 11 years ago

verified fixed  April 8th, 2012  built from http://hg.mozilla.org/mozilla-central/rev/b0d842380959

Tested this multiple times  using today's build, the app bar is now refreshed and I can no longer produce this bug.

	Kamil Jozwiak [:kjozwiak] Reporter
	Comment 9 • 11 years ago

Went through the following "Defect" for iteration #5 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-13-03-09-27-mozilla-central/

Found an issue when going through the following defect but I don't think its related to this change as I can semi-reproduce it on older builds. Will block the main "Story"

Went through the following tests to ensure that issue has been resolved:

- Went through all the steps outlined in Comment 0
- Ensured that the "App Bar" is dismissed and the "Star" is deselected (websites that are not bookmarked) when using CTRL + TAB
- Ensured that the "App Bar" is dismissed and the "Star" is deselected (websites that are not bookmarked) when using ALT <- & -> arrows
- Ensured that the "Star" is always enabled when a website is bookmarked
- Ensured that websites appear under "Bookmarks" on the awesome screen
- Ensured that websites are removed from "Bookmarks" when the "Star" is deselected