Closed
Bug 855889
Opened 12 years ago
Closed 5 years ago
Remove "print.use_global_printsettings" pref
Categories
(Core :: Printing: Setup, defect)
Core
Printing: Setup
Tracking
()
RESOLVED
FIXED
mozilla75
Tracking | Status | |
---|---|---|
firefox75 | --- | fixed |
People
(Reporter: dholbert, Assigned: jwatt)
References
()
Details
(Whiteboard: [print2020_v75])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The pref "print.use_global_printsettings" has defaulted to true (and had no UI aside from about:config for tweaking it) since bug 131852 landed, back in 2002.
If it's toggled to false, we'll supposedly store different print-settings for different browser-windows. (At least, that's what the comment in all.js says)
This is a very odd use-case, and I'd be very surprised if it still works correctly, given that our print-settings code has basically no automated tests, and only users who've stumbled upon the about:config pref will have managed to test it.
In short: I think this pref falls into the category of un-tested who-knows-if-it-works legacy code for an highly unusual use-case, and as such, I think we should remove it.
(NOTE: For anyone who actually depends on this pref and really needs to multiple browser-windows open side-by-side with different print settings: they'd be better served by simply running two separate firefox processes, with different profiles, or running Firefox and Chrome simultaneously, etc.)
Reporter | ||
Updated•12 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [mentor=dholbert][lang=c++]
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Whiteboard: [mentor=dholbert][lang=c++]
Updated•8 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Reporter | ||
Updated•5 years ago
|
Assignee: dholbert → jwatt
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/832f445b5347
Remove the print.use_global_printsettings pref. r=dholbert
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/b1eb4ea24f42
remove calendar/ usage of gPrintSettingsAreGlobal. rs=me DONTBUILD
Assignee | ||
Updated•5 years ago
|
Whiteboard: [print_v75]
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Whiteboard: [print_v75] → [print2020_v75]
You need to log in
before you can comment on or make changes to this bug.
Description
•