Closed Bug 856141 Opened 12 years ago Closed 11 years ago

Reviewers should not be able to approve their own themes

Categories

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
2013-04-04

People

(Reporter: amyt, Assigned: kngo)

References

Details

Anyone who is reviewing themes should not be able to moderate their own. Might be good to gray out the moderation buttons so a reviewer will still see their theme in the queue, just not be able to approve it. Please turn off this feature on dev to facilitate testing.
Priority: -- → P2
Target Milestone: --- → 2013-04-04
To clarify, I believe admins should still be able to review their own (at least that's how it worked on GP).
Thanks for clarifying, I agree.
Assignee: nobody → cvan
Status: NEW → ASSIGNED
https://github.com/mozilla/zamboni/commit/667b2c6 (In reply to Amy Tsay [:amyt] from comment #0) > Anyone who is reviewing themes should not be able to moderate their own. > Might be good to gray out the moderation buttons so a reviewer will still > see their theme in the queue, just not be able to approve it. As a reviewer (but non-admin), when I request a pool of themes to review, my pending themes will not show up. If I visit the single review page for my theme, I will be able to see it but it will be "unapprovable" (not reviewable). When we add a tabular list of pending themes (and search) with bug 855191 then we can show mine. I hope this is satisfactory - let me know if this behaviour is not acceptable. Thanks!
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Which tab would your own theme show up on?
Our reviewer vanillaorchids is reporting that she was able to approve two of her own themes: https://addons.mozilla.org/firefox/addon/catching-fire-haymitch/ https://addons.mozilla.org/firefox/addon/the-hobbit-galadriel/
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: cvan → ngoke
Status: REOPENED → RESOLVED
Closed: 12 years ago11 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.