Anyone who is reviewing themes should not be able to moderate their own. Might be good to gray out the moderation buttons so a reviewer will still see their theme in the queue, just not be able to approve it. Please turn off this feature on dev to facilitate testing.

To clarify, I believe admins should still be able to review their own (at least that's how it worked on GP).

Thanks for clarifying, I agree.

https://github.com/mozilla/zamboni/commit/667b2c6 (In reply to Amy Tsay [:amyt] from comment #0) > Anyone who is reviewing themes should not be able to moderate their own. > Might be good to gray out the moderation buttons so a reviewer will still > see their theme in the queue, just not be able to approve it. As a reviewer (but non-admin), when I request a pool of themes to review, my pending themes will not show up. If I visit the single review page for my theme, I will be able to see it but it will be "unapprovable" (not reviewable). When we add a tabular list of pending themes (and search) with bug 855191 then we can show mine. I hope this is satisfactory - let me know if this behaviour is not acceptable. Thanks!

Which tab would your own theme show up on?

Our reviewer vanillaorchids is reporting that she was able to approve two of her own themes: https://addons.mozilla.org/firefox/addon/catching-fire-haymitch/ https://addons.mozilla.org/firefox/addon/the-hobbit-galadriel/

This seems to be happening again. Regression? https://forums.mozilla.org/addons/viewtopic.php?f=30&t=14447&start=25#p29828

Reopen if it happens again. https://github.com/mozilla/zamboni/commit/3d1f39d90a473714ac90819da13dded821d87bd6