Closed
Bug 856402
Opened 11 years ago
Closed 11 years ago
Crash [@ nsUserFontSet::LogMessage] removing a stylesheet while a font loads
Categories
(Core :: Graphics: Text, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: jruderman, Assigned: jtd)
References
Details
(Keywords: assertion, testcase)
Crash Data
Attachments
(4 files)
1. mkdir -p ~/px/y 2. cp ~/Desktop/prefs.js ~/px/y/ 3. firefox -profile ~/px/y/ ~/Desktop/h.html prefs.js: user_pref("security.fileuri.strict_origin_policy", false); The testcase timing is fragile. You might have to try with several setTimeout values, CLEARING THE PROFILE DIRECTORY each time (!?).
Reporter | ||
Comment 1•11 years ago
|
||
Reporter | ||
Comment 2•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → jdaggett
Assignee | ||
Comment 3•11 years ago
|
||
Did you mean to leave an un-closed comment in the <style> section? Guessing not...
Assignee | ||
Comment 4•11 years ago
|
||
GetParentStyleSheet can null the parent sheet pointer but return NS_OK, so need to null-check this before use.
Attachment #732668 -
Flags: review?(dbaron)
Comment 5•11 years ago
|
||
Comment on attachment 732668 [details] [diff] [review] patch, null-check the result of GetParentStyleSheet >+ // bug 856402 - GetParentStyleSheet can return a null sheet ptr I'd drop the bug number, but add "if the style sheet is removed while the font is loading", so that the comment explains why it can be null r=dbaron
Attachment #732668 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Pushed to mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/cec16f7093d6
Updated•11 years ago
|
Crash Signature: [@ NS_DebugBreak | nsCOMPtr<nsIDOMCSSStyleSheet>::operator->()]
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cec16f7093d6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Reporter | ||
Comment 8•11 years ago
|
||
(In reply to John Daggett (:jtd) from comment #3) > Did you mean to leave an un-closed comment in the <style> section? Guessing > not... I did mean to do that. The script removes the comment, activating the contents of the stylesheet. There might be a better way to construct a testcase ;)
You need to log in
before you can comment on or make changes to this bug.
Description
•