Closed
Bug 856424
Opened 12 years ago
Closed 11 years ago
Unpref Components for content
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla26
| Tracking | Status | |
|---|---|---|
| firefox22 | - | --- |
People
(Reporter: bholley, Assigned: emk)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
Now that bug 790732 has landed, the Components object is no longer defined in content scopes. However, this behavior is behind a pref, and we may end up needing to flip that pref on aurora or beta for web compat.
Once this pref makes it all the way to release, we can remove it, which will pave the way for a lot of important refactoring and simplification.
|
||
Comment 1•12 years ago
|
||
Any call on whether we'll want to do this for FF22?
tracking-firefox22:
--- → ?
|
||
Comment 2•12 years ago
|
||
If we remove the pref code, I think that can ride the trains, so I wouldn't take this in 22 anyway.
|
|
||
Updated•11 years ago
|
|
Assignee | |
Comment 3•11 years ago
|
||
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #791839 -
Flags: review?(bobbyholley+bmo)
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 791839 [details] [diff] [review]
patch
test_sandbox.xul failed.
Attachment #791839 -
Flags: review?(bobbyholley+bmo)
|
|
Assignee | |
Comment 6•11 years ago
|
||
Resolved the test failure.
Attachment #791839 -
Attachment is obsolete: true
Attachment #792230 -
Flags: review?(bobbyholley+bmo)
|
Reporter | |
Comment 7•11 years ago
|
||
Comment on attachment 792230 [details] [diff] [review]
patch v2
Review of attachment 792230 [details] [diff] [review]:
-----------------------------------------------------------------
Wow, this is awesome! Thanks a ton for the patch. r=bholley
Attachment #792230 -
Flags: review?(bobbyholley+bmo) → review+
|
|
Assignee | |
Comment 8•11 years ago
|
||
Flags: in-testsuite+
|
||
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•11 years ago
|
Keywords: dev-doc-needed
|
|
Assignee | |
Comment 10•11 years ago
|
||
Components-in-content was already disabled by flipping the pref since Firefox 22. This bug just removed the flipped pref. Also, I couldn't find any documents explaining about thedom.omit_components_in_content pref (including Firefox 22 compatibility docs).
So I don't think we need to update documents.
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•