Closed
Bug 856840
Opened 12 years ago
Closed 12 years ago
Kill FindWrapper
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
In the absence of GWNOJO, I don't see any reason why this is necessary. But that holder stuff always makes my head hurt.
Assignee | ||
Comment 1•12 years ago
|
||
Comment 3•12 years ago
|
||
Comment on attachment 732388 [details] [diff] [review]
Kill FindWrapper. v1
Review of attachment 732388 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/xpconnect/wrappers/XrayWrapper.cpp
@@ +535,1 @@
> JSObject *holder = GetHolder(wrapper);
Are we guaranteed that wrapper is an Xray wrapper? Is it not possible to stick the wrapper as the prototype of something and end up here as the result of a get through the third object? If that is the case, then it seems like we need to class-check wrapper here.
Attachment #732388 -
Flags: review?(mrbkap)
Assignee | ||
Comment 4•12 years ago
|
||
Even with some digging, Waldo was unsure as to whether the object parameter
to a JSClass::{get,set}Property hook takes the host object or the receiver
in this case. Let's be safe as Blake suggested.
Attachment #732388 -
Attachment is obsolete: true
Attachment #734727 -
Flags: review?(mrbkap)
Updated•12 years ago
|
Attachment #734727 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•