Jason Smith [:jsmith] Reporter
	Description • 11 years ago

If an event is viewed that contains links in the notes, we should allow those links to be clickable. Right now, they aren't, which makes accessing a URL from a calendar event a rough user experience - you'll have to memorize the URL or write it down, move to the browser, and type it in.

Let's make those links clickable in the read only view.

	Jason Smith [:jsmith] Reporter
	Comment 1 • 11 years ago

Technically I'd more call this a UX feature, but let's see what UX thinks how important this is. I personally found this quite annoying that this doesn't exist, as my work calendar contains links in the events.

	Rob MacDonald [:robmac]
	Comment 2 • 11 years ago

Yes, the links should be clickable. As a starting point this includes both URLs and emails. If feasible, it should also include phone numbers (initiate dialer).

There's also the issue of attachments. In this case we should launch the related viewer as per https://www.dropbox.com/s/4737sg5tfvbi72x/meta-pattern-previews.pdf. This may be beyond the scope of the current feature, though, so I'll add a needs info for Peter Dolanjski.

	Peter Dolanjski [:pdol]
	Comment 3 • 11 years ago

It is certainly a good suggestion and tablestakes functionality.  We can't consider such a new feature for the imminent releases, but I'd like to understand how much effort would be involved to enable urls, email addresses and phone numbers, in particular.

Ben, would you be the right individual to comment on this?

One approach would be to only make these clickable when proper html href attributes are used.  Another option would be to parse the body for recognizable links.

	Rob MacDonald [:robmac]
	Comment 4 • 11 years ago

Re-posting link to patterns document as dropbox link seems to have been broken...

https://www.dropbox.com/s/vbxes8onsv58ir7/meta-pattern-previews.pdf

	Ben Francis [:benfrancis]
	Comment 5 • 11 years ago

I don't know much about how the calendar currently behaves when it encounters HTML content, I suggest asking James.

	James Lal [:lightsofapollo]
	Comment 6 • 11 years ago

We have code for this in the email app which we can-reuse more globally. Handling html descriptions is much more difficult because we need to deal with sanitizing the html but again email handles this now.

	James Lal [:lightsofapollo]
	Comment 7 • 11 years ago

re-nominating for leo? This is a very simple to implement feature and we can re-use email's implementation and continue to improve it over time.

	Alex Keybl [:akeybl]
	Comment 8 • 11 years ago

Please nominate for uplift to v1.1 once resolved, but not a blocker.

	Tiffanie Shakespeare [:tif]
	Comment 9 • 9 years ago

Adding qawanted - is this still an issue?

	Pi Wei Cheng [:piwei] (inactive)
	Comment 10 • 9 years ago

If I understand this bug correctly, this is still reproducible on latest Aries.

What I did:
1) Open Calendar, and create an event (online with an account or offline does not matter)
2) During event creation, make sure to add an URL like http://www.google.com in the Notes section down below. Finish creating the event.
3) Back in Calendar view, tap to view the event in detail created at step 1/step 2
4) Attempt to tap on the link and see if it's tappable

Result: It is not tappable. See screenshot.

Tested and occurred on:
Device: Aries
BuildID: 20151123143009
Gaia: bae13c9ac6a91beecd7c94384e2aef25ed1a3214
Gecko: d3d286102ba7f8801e9dfe12d534f49554ba50c0
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6 Master) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

	Jayme Mercado [:JMercado] (Inactive 3/4/2016)
	Comment 11 • 9 years ago

Tiffanie it seems this is still an issue.  It was never a blocker before, not sure if you consider it more important now than they did back when the bug was written.

	Tiffanie Shakespeare [:tif]
	Comment 12 • 9 years ago

Thanks so much guys! Just trying to go through old bugs and get them organized :)

	Alexey Yakimov
	Comment 14 • 9 years ago

Comment on attachment 8696954 [details]
[gaia] ruvsmirnov:bug-856888-calendar-notes-links-clickable-provided > mozilla-b2g:master

Gareth, could you please review the patch?

	vladimir.smirnov2 Assignee
	Comment 15 • 9 years ago

Gareth, I leave comment on this patch. Could you please see it?

	Julien Wajsberg [:julienw]
	Comment 16 • 9 years ago

Comment on attachment 8696954 [details]
[gaia] ruvsmirnov:bug-856888-calendar-notes-links-clickable-provided > mozilla-b2g:master

I left some ocmments on github already. Especially I'm fine moving link_helper to shared, but not activity_picker. I think integrating the 3 types of link into link_action_handler would be better, especially that the existing activity_picker contains activities that are useful in SMS but not in Calendar. (and it also is quite outdated nowadays).

adding the r? to myself so that I can check on a device.

	Julien Wajsberg [:julienw]
	Comment 17 • 9 years ago

Comment on attachment 8696954 [details]
[gaia] ruvsmirnov:bug-856888-calendar-notes-links-clickable-provided > mozilla-b2g:master

OK this seems to work for me, but I'd still prefer that we follow my previous comment.

Thanks !

	BMO Automation
	Comment 18 • 6 years ago

Firefox OS is not being worked on