Closed Bug 856910 Opened 12 years ago Closed 11 years ago

[Settings] List installed IME and corresponding layouts so the user can enable/disable them.

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

x86
macOS
defect

Tracking

(blocking-b2g:koi+)

RESOLVED FIXED
blocking-b2g koi+

People

(Reporter: evanxd, Assigned: arthurcc)

References

Details

(Whiteboard: [ucid:SystemPlatform7], [FT:System-Platform], [Sprint: 2])

Attachments

(1 file, 3 obsolete files)

Attached image The UI design of Keyboard setting (obsolete) (deleted) —
Please refer to bug 816869. For supporting 3rd-party keyboards, we should need a new design of keyboard setting page in Settings App. I have a proposal. We could simply list all keyboards(input methods) installed, and user could enable/disable all of them. It looks like the "The UI design of Keyboard setting" picture in the attachment.
Summary: [Settings] UI design of Keyboard setting in Settings App → [Settings] UI design of Keyboard setting in Settings App.
Flags: needinfo?(jcarpenter)
Hi Evan, I've responded to the email main thread with an update on the original proposal from Neo. He and I will be discussing this week in London and then follow up on this.
Flags: needinfo?(jcarpenter)
Hi Josh, I got it. Thanks. :)
Josh, any news on this?
Flags: needinfo?(jcarpenter)
Reassigning to Neo as he's taking care of 3rd party IME.
Flags: needinfo?(jcarpenter) → needinfo?(nhsieh)
Update bug title to express engineering work here.
Assignee: nobody → gchen
Summary: [Settings] UI design of Keyboard setting in Settings App. → [Settings] List installed IME and corresponding layouts so the user can enable/disable them.
Attached file Latest UX design of IME. see Page 6 (obsolete) (deleted) —
We've got a (draft) design from UX team as a reference for this bug. @Neo, Please update here for more details.
Attachment #732160 - Attachment is obsolete: true
Blocks: 891674
Comment on attachment 775320 [details] Latest UX design of IME. see Page 6 obsolete here because there is a copy in bug 891678 (meta bug), I will keep update there.
Attachment #775320 - Attachment is obsolete: true
Assignee: gchen → arthur.chen
v1.2 feature. Nominate for koi+.
blocking-b2g: --- → koi?
blocking-b2g: koi? → koi+
Attached file WIP v1 (obsolete) (deleted) —
Evelyn, the commit is WIP v1. Since this is only a WIP, I did not add detail comments yet. I described the code briefly in github. Would you mind take a look on the overall design? Thanks!
Attachment #783171 - Flags: feedback?(ehung)
Neo, could you help provide inputs on how to handle the case of users disabling all keyborad layouts?
Whiteboard: [ucid:SystemPlatform7], [FT: System Platform], [Sprint: 2]
Priority: -- → P1
This is the pull request to add 3rdParty keyboard support. Please be informed this change would need Gecko m-c to test with. For this bug, please help review bd22f6e0b76d1e5a4c4551f4082db4fff79ca871 only, the other 2 commits will be reviewed by other module peers/owners. The patch also covers bug 893557. Evelyn, could you help review it? Thanks!
Attachment #783171 - Attachment is obsolete: true
Attachment #783171 - Flags: feedback?(ehung)
Attachment #790126 - Flags: review?(ehung)
I've tested on the phone, and I need more time to review the whole bunch of the code.
The other 2 parts of IME framework, i.e. keyboard app and keyboard manager have been r+'ed. So this is last part that we need to get the 1st phase implementation into Gaia master. Evelyn, Can you help to get to the review soon or we need to find someone else, like Kaze to help? Thank you.
Flags: needinfo?(ehung)
I'm reviewing and discussing with Arthur. Should be done today.
Flags: needinfo?(ehung)
Comment on attachment 790126 [details] link to https://github.com/mozilla-b2g/gaia/pull/11529 r=me. Arthur, I have to say: good job! Thanks for the big patch. As we discussed, the patch is an experiment to demonstrate how MVC/MVVM pattern can be applied in Settings app. I hope we can make our point more clear by separating it to two commits, refactoring the code structure, and filing another bug for discussion. Please address my commented on Github and update your commits, then flag a review to me for a check. Thank you so much. :)
Attachment #790126 - Flags: review?(ehung)
Comment on attachment 790126 [details] link to https://github.com/mozilla-b2g/gaia/pull/11529 Evelyn, thank you for reviewing such a huge patch. And the suggestions are really helpful! Comment addressed as requested. As for a separate commit for the mvvm part, since the patch is combined with commits from Rudy and Gary, we will squash the commits before merge to master. I will make sure the mmvm part merged as a separate commit.
Attachment #790126 - Flags: review?(ehung)
Attachment #790126 - Flags: review?(ehung) → review+
Whiteboard: [ucid:SystemPlatform7], [FT: System Platform], [Sprint: 2] → [ucid:SystemPlatform7], [FT:System-Platform], [Sprint: 2]
Landed to Gaia master, bc8c1c962addd419b48ba12c6d8ddabdf9805391
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
backed out as part of the general backout of the 3rd party keyboard customizations (https://github.com/mozilla-b2g/gaia/commit/42aa1e2ccd22e464bffe6b22ee1182cece5dc2dc) Due to b2g-desktop failures (fail to start) https://travis-ci.org/mozilla-b2g/gaia/builds/10571231#L129.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Flags: needinfo?(nhsieh)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: