Steps to reproduce: 1. Connect phone with a carkit which supports sending DTMF tones. 2. Make a call and listen to DTMF tones on other side while pressing num keys on car kit. no DTMF tones are heard

(leo+ as this is mandatory for HFP cert)

assign to Eric. Feel free to reassign to Shawn or Gina.

Duplicate of 831632, will help to follow up.

The problem here is Bluetooth car kit sends "AT+VTS=<DTMF>". BluetoothHfpManager would call NotifyDialer which indicates Dialer to handle DTMF command. In dialer.js, btCommandHandler(message) shall parse command "VTS=<DTMF command>" and use TonePlayer to play DTMF tone. Command would looks like VTS=1, DTMF command should be one of 0-9, '*' or '#'.

Hi Etienne, Since implementation requires to change in gaia dialer part, would you help to modify dialer.js?

Shawn, I will help on the gaia part.

Arthur, usually DTMF tone for Bluetooth, there are two requirements that gaia part could help to achieve: 1. Generate DTMF tone sound, so user can hear DTMF tone through Bluetooth SCO (optional) * TonePlayer 2. Send DTMF tone through network (mandatory) * navigator.mozTelephony.startTone

(In reply to Arthur Chen [:arthurcc] from comment #7) > Shawn, I will help on the gaia part. Cool, let me know if you need any help.

Etienne, could you help review the change? Thanks!

Comment on attachment 736111 [details] Link to https://github.com/mozilla-b2g/gaia/pull/9105 Not a big fan of faking mouse events internally for this. The requirement is clear: play the DTMF tone and let the user hear it, and we have pretty accessible functions to do that. My suggestion is to add only a |press(value)| method to the KeypadManager that will directly: - call |telephony.startTone(key)| - call |TonePlayer.start(gTonesFrequencies[value], true)| (we're always doing short presses via Bluetooth, so we should pass true as a second parameter) - set a "nextTick" timeout that calls: + |telephony.stopTone()| + |TonePlayer.stop()| Then instead of having a |click(value)| function in oncall.js you can just call |KeypadManager.press(value)|

Comment on attachment 736111 [details] Link to https://github.com/mozilla-b2g/gaia/pull/9105 I didn't realize that we only need to play the tone. Patch updated, please help review it, thanks!

Comment on attachment 736111 [details] Link to https://github.com/mozilla-b2g/gaia/pull/9105 Thanks!

Thanks Etienne! master: https://github.com/mozilla-b2g/gaia/commit/70b7c4b835da29247ecd55d85415eea43c83428c

Let's land this on v1-train?

v1-train: https://github.com/mozilla-b2g/gaia/commit/a7ecc7446b3a15cd3aed1490080de77b3bbdfe6e

Haven't fixed the queries yet, so I'm using qawanted for now. Someone needs to see if this bug also reproduces on v1.01.

Mozilla QA doesn't have access to a carkit, so someone with one will need to see if this repros on 1.0.1.

Not going to be really easy to test on 1.01 and I question if we care about if we need this on 1.01. Michael - Let's say this bug reproduces on 1.01. Would we tef+ if it reproduces? If not, then QA probably doesn't need to spend time here figuring out if it reproduces on 1.01.

This is not a v1.0.1 requirement from our POV

This blocks HFP AG_TDC test case. Please refer to test case TC_AG_TDC_BV_01_I

Supporting DTMF tone is mandatory for HFP spec. Blocking certification test case.

(In reply to Shawn Huang from comment #22) > This blocks HFP AG_TDC test case. Please refer to test case TC_AG_TDC_BV_01_I tef?

Michael, based in comment 21 you think is not a blocker for tef+ but it seems withot this fixed, it is not possible to pass certification, can you please clarify?

Sure, the bug was raised against v1.1 by our test folks but that's because this test case was not covered as a part of our v1.0 test. So by comment 21, I was merely saying that we have no opinion regarding it blocking v1.0. Comment 23 seems to say that this might be BT cert so that seems like a good reason to block on it

Arthur, can you land it in 1.0.1 as it is tef+

v1.0.1: https://github.com/mozilla-b2g/gaia/commit/cde700cd29a03a7e4eca5dcbe25e2dd16a189c37

Unable to test this issue. Don't have a bluetooth car kit. Marking as QARegressExclude