Closed
Bug 858094
Opened 12 years ago
Closed 12 years ago
Request More Info field required error is displayed for every listed theme
Categories
(Marketplace Graveyard :: Reviewer Tools, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
2013-04-04
People
(Reporter: cboldan.mozbugs, Assigned: kngo)
References
()
Details
Steps to reproduce:
1. Load Theme Review Queue landing page https://marketplace-dev.allizom.org/reviewers/themes/queue/
2. Press the Request More Info button from a listed theme
3. Press the "Continue" button without entering any text
4. Press the Request More Info button from another listed theme
Expected results:
There are no errors displayed in the Request More Info drop-down box.
Actual results:
Field Required error is displayed in every Request More Info drop-down box for all the listed themes. Also, when the error is displayed, the text box gets bigger. Issue is also reproducing for the Flag and Duplicate buttons.
Notes/Issues:
Verified on FF23 (Win 7).
Screencast for this issue http://screencast.com/t/PmThcPnmC9
Comment 1•12 years ago
|
||
Kevin, I think it'd totally be sufficient to throw a `required` attribute on the `input`. I'm worried the django form logic is wrong though for this to even be happening. Ideas?
Assignee: nobody → ngoke
Priority: -- → P3
Assignee | ||
Comment 2•12 years ago
|
||
I'll do required, I don't think I knew it about it back then.
Comment 3•12 years ago
|
||
(In reply to Kevin Ngo [:ngoke] from comment #2)
> I'll do required, I don't think I knew it about it back then.
Is that error django form validation or JS validation? Why would this happen in the first place is my question?
Assignee | ||
Comment 4•12 years ago
|
||
JS. Happened because it was:
$('.required') instead of $('.required', themes[currentTheme])
Assignee | ||
Comment 5•12 years ago
|
||
Fix for now, will try to refactor later
https://github.com/mozilla/zamboni/commit/9f333cb9cf9d1d8a812b5146148af5e93c1bc8d0
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•12 years ago
|
||
Verified as fixed in https://marketplace-dev.allizom.org/reviewers/themes/queue/ on FF23 (Win 7).
Postfix screencast http://screencast.com/t/UaliZ1EIg8R
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•