Closed
Bug 858290
Opened 12 years ago
Closed 12 years ago
Need to enable focusmanager.testmode for tests run against B2G desktop builds
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox23 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)
RESOLVED
FIXED
mozilla23
People
(Reporter: davehunt, Assigned: davehunt)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
Interacting with the keyboard or select options in the B2G desktop client requires focus on the application unless focusmanager.testmode is enabled in the preferences.
I see a couple of options:
1. Add required preferences to the profile when launching the binary specified in the MarionetteTestRunner. We already set a few preferences here, but we'd be adding focusmanager.testmode and setting these even if a profile is specified. See http://hg.mozilla.org/mozilla-central/file/c232bec6974d/testing/marionette/client/marionette/geckoinstance.py#l20
2. Add a B2GDesktopProfile to mozprofile that specifies this and any other required preferences for the B2G desktop client. This would also likely involve adding a B2GDesktopRunner in mozrunner, and adding a way to determine the binary specified on the command line of MarionetteTestRunner. Perhaps by an --application option, similar to Mozmill.
Comment 1•12 years ago
|
||
GeckoInstance was designed for desktop Firefox; I wonder how many differences we'll eventually want for B2G desktop builds? It might make sense to create a B2GDesktopInstance subclass of this which has its own set of prefs that get used even when you specify a profile.
I like that approach better than adding classes to mozprofile/mozrunner, since it's a lot lighter-weight.
Assignee | ||
Comment 2•12 years ago
|
||
Sounds good to me. How would you suggest we determine the class to use? Should we inspect the binary specified or just have an --application option?
Assignee | ||
Comment 3•12 years ago
|
||
Assignee: nobody → dave.hunt
Attachment #733840 -
Flags: review?(jgriffin)
Comment 4•12 years ago
|
||
Comment on attachment 733840 [details] [diff] [review]
Set focusmanager.testmode for B2G desktop. v1.0
Review of attachment 733840 [details] [diff] [review]:
-----------------------------------------------------------------
Cool, thanks.
Attachment #733840 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Landed on inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f719ebae709
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Assignee | ||
Comment 7•12 years ago
|
||
Thanks, can we get this uplifted to b2g18?
tracking-b2g18:
--- → ?
Comment 8•12 years ago
|
||
this looks to be an a=testonly since it's a patch to marionette - anything i'm missing here?
tracking-b2g18:
? → ---
Assignee | ||
Comment 9•12 years ago
|
||
status-b2g18:
--- → fixed
Comment 10•12 years ago
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•