Evan Tseng [:evanxd] Reporter
	Description • 11 years ago

Please refer to bug 816912.
And the mate bug of this bug is bug 816869.

Integrate the new keyboard manager supported 3rd-party keyboard apps 
with switch and show layout list functions in Keyboard app.

	Evan Tseng [:evanxd] Reporter
	Comment 1 • 11 years ago

Thanks :)

	Evelyn Hung
	Comment 2 • 11 years ago

To test this patch, please also apply patch in the bug 816912(In reply to Evan Tseng from comment #1)
> Created attachment 733723 [details]
> Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9001
> 
> Thanks :)

To test this patch, I guess we also need patch in the bug 816912

	Evan Tseng [:evanxd] Reporter
	Comment 3 • 11 years ago

Hi Evelyn,

Yes, you are right.
Thanks.

To test these two patch, we might also need the new Keyboard APIs supporting.
For Keyboard App, it used the window.navigator.mozKeyboard.inputType API.
And I already wrote the email to Xulei.

	Evelyn Hung
	Comment 4 • 11 years ago

Hi Xulei, any schedule of landing mozKeyboard API in Gecko side? We hope we could land both keyboard manager (in bug 816912) and keyboard app patches (here) by the end of this week. We don't want to break anything on gaia master so we should make sure there is no impact if mozKeyboard API can't be landed in time.

	Evelyn Hung
	Comment 5 • 11 years ago

Comment on attachment 733723 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9001

commented on Github. 
I'll leave the r? decision to Rudy because he knows more keyboard app.

	Evelyn Hung
	Comment 6 • 11 years ago

(In reply to Evelyn Hung [:evelyn] from comment #5)
> Comment on attachment 733723 [details]
> Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9001
> 
> commented on Github. 
> I'll leave the r? decision to Rudy because he knows more keyboard app.

Rudy, please test carefully to make sure we didn't break anything. The keyboard app should work as before.

	Evan Tseng [:evanxd] Reporter
	Comment 7 • 11 years ago

Hi Evelyn,

I got it.
And I also updated the code for your comments.

Thanks. :)

	Yuan Xulei [:yxl] (Leave from May 18)
	Comment 8 • 11 years ago

(In reply to Evelyn Hung [:evelyn] from comment #4)
> Hi Xulei, any schedule of landing mozKeyboard API in Gecko side? We hope we
> could land both keyboard manager (in bug 816912) and keyboard app patches
> (here) by the end of this week. We don't want to break anything on gaia
> master so we should make sure there is no impact if mozKeyboard API can't be
> landed in time.

The patch of extended mozKeyboard API will be ready this week, but I can't not ensure that it can land by this weekend, since it may require more than one week to review.

To remove the dependency of extended mozKeyboard API, you only need to remove the reference of  mozKeyboard.inputType in gaia side.

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 9 • 11 years ago

Hi all,

Thanks for the work.
I found several issues when I test this patch with that of bug 816912.

1. The latency to show the keyboard is noticeable.
   Most of the time, the keyboard will be shown with some keys that are not rendered completely.
   Sometimes, it will show the background (of homescreen) first and then the keyboard appears.

2. Long press the "switch language" and select one of the layouts.
   There are several issues here, sometimes we cannot switch the language again.
   Let's talk about this face-to-face.

3. Right now all keyboard layouts are enabled by default.
   Is this by intention?

4. :djf made some modification in 132c5a712ec4d4e92208ba4fc65ca98b8be00b31 for keyboard auto-correction, we might need to update the code to accommodate that change, or it seems word suggestion could not work.

	Evan Tseng [:evanxd] Reporter
	Comment 10 • 11 years ago

Hi all,

I found a new issues.

After switched to a new keyboard layout from default one, user clicked another input filed. And the keyboard manager showed the default layout, not the new one.

	Evan Tseng [:evanxd] Reporter
	Comment 11 • 11 years ago

Hi all,

This bug are waiting for UI spec and new Keyboard APIs.

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 12 • 11 years ago

Comment on attachment 733723 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9001

clear the review flag for now.

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 13 • 11 years ago

Will take this and give an update patch.

	Evan Tseng [:evanxd] Reporter
	Comment 14 • 11 years ago

Hi Rudy,

Thanks for your help. :)

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 15 • 11 years ago

WIP here,
https://github.com/RudyLu/gaia/tree/3rdParty_keyboard

The latest change to integrate the new Keyboard app with Gary's work on keyboard_manager is this commit,
https://github.com/RudyLu/gaia/commit/ce92c95cf4139f7da78caa7db3cd82a244dd3ede

	Ivan Tsay (:ITsay)
	Comment 16 • 11 years ago

Add white board key words for tracking

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 17 • 11 years ago

Pointer to Github pull-request

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 18 • 11 years ago

Comment on attachment 790117 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11527

Hi David, Tim,

Please help review the 1st part of the big changes we need for 3rd-party keyboard support.

I would need your help to review this commit only, which is focused on keyboard app itself.
https://github.com/mozilla-b2g/gaia/commit/92235a8ce3ea4a4902bb11871ba485158b8e486b 

The other 2 commits are needed to test the new IME framework and will be reviewed by other module peers/owners but feel free to take a look if you are interested.

Some cleanup and work are not done yet, listed below, but I would like to send this patch first and get your feedback.
  
[Work to be done]
  1. Move settings from mozSettings to keyboard app itself.
     - and cleanup all references to keyboard layout settings.
  2. Modify latin IME to use onsurroundingtextchange and composition related API.
  
Thank you.

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 19 • 11 years ago

Comment on attachment 790117 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11527

Looks good, some nits need to be addressed though.

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 20 • 11 years ago

Comment on attachment 790117 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11527

I think I switch the wrong flag :-/ Sorry about that.

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 21 • 11 years ago

Send another pull request (commits squashed) to make the original one keep the review comments.
carry over the r+.

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 22 • 11 years ago

Landed to Gaia master (finally!!)
bc8c1c962addd419b48ba12c6d8ddabdf9805391

	James Lal [:lightsofapollo]
	Comment 23 • 11 years ago

backed out as part of the general backout of the 3rd party keyboard customizations (https://github.com/mozilla-b2g/gaia/commit/42aa1e2ccd22e464bffe6b22ee1182cece5dc2dc) Due to b2g-desktop failures (fail to start) https://travis-ci.org/mozilla-b2g/gaia/builds/10571231#L129.

	Ivan Tsay (:ITsay)
	Comment 24 • 11 years ago

Remove ucid from the white board since this is engineering bug

	Ed Morley [:emorley]
	Comment 25 • 11 years ago

Something in this gaia.json auto-commit:
https://hg.mozilla.org/integration/b2g-inbound/rev/31ca106e662c

...broke the gaia unit tests, eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=27215367&tree=B2g-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=27214598&tree=B2g-Inbound

The auto-commit corresponds to:
https://hg.mozilla.org/integration/gaia-central/pushloghtml?fromchange=c258483698afbf2c2b7f27f8fa16922d0ee48880&tochange=75e0fbd934e2c835db9ecd10ec6b2900b357d53c

So this and the others in that push have been backed out:
https://github.com/mozilla-b2g/gaia/commit/c2f23f132accb38af4a46f9171bc6be25fdb99a1
https://github.com/mozilla-b2g/gaia/commit/9a8098e8a6b86a32da0eef08e507ab689435dfee
https://github.com/mozilla-b2g/gaia/commit/884d0af45bc605c8e943e3080b2a909461795953
https://github.com/mozilla-b2g/gaia/commit/6a653be7c8b34f263342ead2037b4f8f3c2aff0e
https://github.com/mozilla-b2g/gaia/commit/cfcb28b5069054c1ad631c5bf4ed9c2a94e06d8b

Please run the gaia unit tests before pushing if possible! :-)

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Assignee
	Comment 26 • 11 years ago

Merged to Gaia master with this rev,
https://github.com/mozilla-b2g/gaia/commit/9fb5802df60a9081846d704def01df814ed8fbd4