Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) Reporter
	Description • 11 years ago

I receive an anonymous gal's sms this morning suggesting that the getOffset call of apps/keyboard/js/keyboard.js create sync reflows and is also useless for latin keyboard. Returning 0,0 for them would be ok for it.

I will make a patch if nobody beats me at it.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) Reporter
	Comment 1 • 11 years ago

The patch just remove x,y parameters to the click method of any imes since I don't see where they are used.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) Reporter
	Comment 2 • 11 years ago

And the patch will also resolve bug 858443.

	David Flanagan [:djf] Assignee
	Comment 3 • 11 years ago

I was hoping to start using those x,y values eventually, to make autocorrect and predictions better.

But not if they are expensive on each keystroke.  Can we cheaply pass the x and y coordinates from the touchstart event instead?

I haven't looked at the patch yet, but maybe I'll just r+ this and then add the x and y back when I'm ready to use them.

	David Flanagan [:djf] Assignee
	Comment 4 • 11 years ago

Comment on attachment 734611 [details] [diff] [review]
Patch

I have not tested the patch, but the change looks safe to me.

For the record, I have no idea what getOffset() and getKeyCoordinateY() are for. They predate my time with the keyboard and have always confused me.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) Reporter
	Comment 5 • 11 years ago

(In reply to David Flanagan [:djf] from comment #3)
> I haven't looked at the patch yet, but maybe I'll just r+ this and then add
> the x and y back when I'm ready to use them.

Please :). Let's not keep expensive things until we really need them.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) Reporter
	Comment 6 • 11 years ago

https://github.com/vingtetun/gaia/commit/c468c590989d888464cf614cf0d6b608f46cfefd

	John Ford [:jhford] CET/CEST Berlin Time
	Comment 7 • 11 years ago

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x  c468c590989d888464cf614cf0d6b608f46cfefd
  <RESOLVE MERGE CONFLICTS>
  git commit

	John Ford [:jhford] CET/CEST Berlin Time
	Comment 8 • 11 years ago

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x  c468c590989d888464cf614cf0d6b608f46cfefd
  <RESOLVE MERGE CONFLICTS>
  git commit

	James Lal [:lightsofapollo]
	Comment 9 • 11 years ago

Can you supply a patch to uplift / uplift yourself on effected branches?

	James Lal [:lightsofapollo]
	Comment 10 • 11 years ago

David, can you supply a patch that applies cleanly?

	David Flanagan [:djf] Assignee
	Comment 11 • 11 years ago

It looks like this patch has already been uplifted.  I don't know how.