Closed
Bug 858759
Opened 12 years ago
Closed 12 years ago
profiler.css in browser/devtools/ should actually be in browser/themes instead
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: vporof, Assigned: anton)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
anton
:
review+
|
Details | Diff | Splinter Review |
Shouldn't it?
Assignee | ||
Comment 1•12 years ago
|
||
Tested on OS X. Going to test it on Linux in a bit and then find someone with Windows to test it for me.
Assignee | ||
Comment 2•12 years ago
|
||
Nvm, my Linux box seems busted.
Reporter | ||
Comment 3•12 years ago
|
||
Comment on attachment 735545 [details] [diff] [review]
Move profiler.css to browser/themes
Review of attachment 735545 [details] [diff] [review]:
-----------------------------------------------------------------
This should theoretically work on other platforms too, but it wouldn't hurt to test.
::: browser/themes/linux/devtools/profiler.css
@@ +1,5 @@
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +%include ../../shared/devtools/profiler.inc.css
\ No newline at end of file
Isn't this a bit premature for just 3 selectors? :) But anyway, I like it.
::: browser/themes/windows/jar.mn
@@ +437,4 @@
> skin/classic/aero/browser/devtools/splitview.css (devtools/splitview.css)
> skin/classic/aero/browser/devtools/styleeditor.css (devtools/styleeditor.css)
> skin/classic/aero/browser/devtools/debugger.css (devtools/debugger.css)
> +* skin/classic/aero/browser/devtools/profiler.css (devtools/profiler.css)
You forgot to put profiler.css in the classic skin as well.
Attachment #735545 -
Flags: review?(vporof) → review+
Reporter | ||
Comment 4•12 years ago
|
||
(R+ with the change in windows/jar.mn)
Assignee | ||
Comment 5•12 years ago
|
||
Added profiler.css to the classic Windows theme. Carrying over r+.
Attachment #735545 -
Attachment is obsolete: true
Attachment #735867 -
Flags: review+
Assignee | ||
Comment 6•12 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•