Closed
Bug 858974
Opened 12 years ago
Closed 8 years ago
Make CommonAnimationManager::mElementData a LinkedList
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: Ms2ger, Unassigned, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [lang=c++][good first bug])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•12 years ago
|
||
Attachment #737242 -
Flags: review?(dbaron)
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 737242 [details] [diff] [review]
Patch v1
Review of attachment 737242 [details] [diff] [review]:
-----------------------------------------------------------------
I think this patch was broken, actually...
Attachment #737242 -
Flags: review?(dbaron)
Updated•8 years ago
|
Assignee: Ms2ger → nobody
Mentor: erahm
Status: ASSIGNED → NEW
Whiteboard: [lang=c++][good first bug]
Comment 3•8 years ago
|
||
Hello Eric,
I'd like to work on this if it still needs fixing.
Ms2ger didn't state what was wrong with the patch, but it was 4 years ago so I'll probably start fresh.
For the record I'm already a C++ contributor here so I'm down with the process, just looking for mentored bugs!
Regards,
Paul
Comment 4•8 years ago
|
||
Hey Paul! Feel free to work on it, please ni? me if you need any help. It's possible it's already been fixed in another refactoring, but just figuring that out would be helpful and I'd be happy to point you to other bugs if that's the case.
Comment 5•8 years ago
|
||
There is no occurrence of "\bmElementData\b" nor "CommonElementAnimationData" accross the repo.
Moreover, AnimationCommon.h shows no occurrence of PRCList, so this bug looks "fixed by refactoring" to me.
> I'd be happy to point you to other bugs if that's the case.
I would love it too, thanks!
Best regards,
Paul
Comment 6•8 years ago
|
||
(In reply to Paul Bignier from comment #5)
> There is no occurrence of "\bmElementData\b" nor
> "CommonElementAnimationData" accross the repo.
> Moreover, AnimationCommon.h shows no occurrence of PRCList, so this bug
> looks "fixed by refactoring" to me.
>
> > I'd be happy to point you to other bugs if that's the case.
> I would love it too, thanks!
> Best regards,
> Paul
Thanks for looking into this Paul! Let go ahead and close this. If you're interested I filed another linked list conversion in bug 1356896. I'll add some more after the weekend as well.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•