Closed
Bug 859087
Opened 12 years ago
Closed 11 years ago
Reduce excessive permutation-testing in imported tests
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
DUPLICATE
of bug 920043
People
(Reporter: ayg, Unassigned)
References
Details
(This change needs to be done upstream and then synced.)
Some of my tests imported from the W3C, for Range in particular, take multiple long lists of ranges and/or points and/or nodes and run some test on every possible permutation of them. This takes forever and tends to cause timeouts. It should be possible to greatly reduce the number of tests that are run without reducing the coverage too much.
I have, however, caught some bugs in UAs that only arise in very particular circumstances -- like an Opera crash if you extractContents() a range that starts at offset 0 in a comment -- so some thought should be given to how best to do this.
Reporter | ||
Comment 1•11 years ago
|
||
I wrote some updates and filed a pull request at the new upstream:
https://github.com/w3c/web-platform-tests/pull/265
I'm back to school tomorrow afternoon, so I might not have time to write up a patch to Gecko to incorporate the changes until my next break (in five weeks). Ms2ger could do it from here without too much work, though, if I don't get to it.
Comment 2•11 years ago
|
||
Isn't it browser's bug? Is it correct to work around the OOM error in the test side?
Any malicious pages can do the same to make a DoS attack, after all.
Comment 3•11 years ago
|
||
Web pages can use as much memory as they want, until something OOMs.
If we want OOM tests we can have such, but tests for Range should doing stuff which is known to be
slow and memory hungry. Range tests should test that the Range API is implemented correctly.
Comment 4•11 years ago
|
||
er, shouldn't be ...
Reporter | ||
Comment 5•11 years ago
|
||
The issue here isn't that the tests are using APIs that are prone to DoS, it's just that a huge number of tests are being run per file. Intelligently reducing the number of tests in a way that doesn't hurt coverage much is just better use of everyone's resources. (I could also fix the fact that some test files use O(N) memory in number of tests, but that's not worth it if the number of tests is cut down anyway to save on runtime.)
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•